Merge pull request ceph#52025 from rzarzynski/wip-ec-drop-unused-requires_overwrite

osd: drop the unused ECTransaction::requires_overwrite()

Reviewed-by: Samuel Just <[email protected]>
Reviewed-by: Matan Breizman <[email protected]>

Author: yuriw

src/osd/ECTransaction.cc

@@ -93,19 +93,6 @@ void encode_and_write(
   }
 }
 
-bool ECTransaction::requires_overwrite(
-  uint64_t prev_size,
-  const PGTransaction::ObjectOperation &op) {
-  // special handling for truncates to 0
-  if (op.truncate && op.truncate->first == 0)
-    return false;
-  return op.is_none() &&
-    ((!op.buffer_updates.empty() &&
-      (op.buffer_updates.begin().get_off() < prev_size)) ||
-     (op.truncate &&
-      (op.truncate->first < prev_size)));
-}
-
 void ECTransaction::generate_transactions(
   WritePlan &plan,
   ErasureCodeInterfaceRef &ecimpl,

src/osd/ECTransaction.h

@@ -32,10 +32,6 @@ namespace ECTransaction {
     std::map<hobject_t,ECUtil::HashInfoRef> hash_infos;
   };
 
-  bool requires_overwrite(
-    uint64_t prev_size,
-    const PGTransaction::ObjectOperation &op);
-
   template <typename F>
   WritePlan get_write_plan(
     const ECUtil::stripe_info_t &sinfo,