Skip to content

Commit 10938b6

Browse files
committed
tools/ceph_dedup: Replace iterator loops with range-based loops
Refactor the code to use modern C++ range-based for loops instead of traditional iterator-based loops, improving code readability Signed-off-by: Kefu Chai <[email protected]>
1 parent 2524bbf commit 10938b6

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

src/tools/ceph_dedup/ceph_dedup_daemon.cc

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -365,11 +365,9 @@ void SampleDedupWorkerThread::crawl()
365365
op.list_snaps(&snap_set, &snap_ret);
366366
io_ctx.operate(target.oid, &op, NULL);
367367

368-
for (std::vector<librados::clone_info_t>::const_iterator r = snap_set.clones.begin();
369-
r != snap_set.clones.end();
370-
++r) {
371-
io_ctx.snap_set_read(r->cloneid);
372-
try_dedup_and_accumulate_result(target, r->cloneid);
368+
for (const auto& clone : snap_set.clones) {
369+
io_ctx.snap_set_read(clone.cloneid);
370+
try_dedup_and_accumulate_result(target, clone.cloneid);
373371
}
374372
} else {
375373
try_dedup_and_accumulate_result(target);

src/tools/ceph_dedup/ceph_dedup_tool.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,10 +1040,8 @@ int make_dedup_object(const po::variables_map &opts)
10401040
op.list_snaps(&snap_set, &snap_ret);
10411041
io_ctx.operate(object_name, &op, NULL);
10421042

1043-
for (std::vector<librados::clone_info_t>::const_iterator r = snap_set.clones.begin();
1044-
r != snap_set.clones.end();
1045-
++r) {
1046-
io_ctx.snap_set_read(r->cloneid);
1043+
for (const auto& clone : snap_set.clones) {
1044+
io_ctx.snap_set_read(clone.cloneid);
10471045
ret = create_new_deduped_object(object_name);
10481046
if (ret < 0) {
10491047
goto out;

0 commit comments

Comments
 (0)