Skip to content

Commit 11f0173

Browse files
committed
ceph-volume: create LVs when using partitions
commit [1] introduced a behavior change. `ceph-volume lvm prepare` used to create VGs/LVs when it was passed partitions for db and/or wal devices. Since commit [1] has been introduced, it made ceph-volume consume the partition directly, it doesn't create LV anymore. Although this doesn't prevent from creating OSDs, this is a behavior change. Fixes: https://tracker.ceph.com/issues/65477 [1] 1e72232 Signed-off-by: Guillaume Abrioux <[email protected]>
1 parent e4c1c9a commit 11f0173

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/ceph-volume/ceph_volume/objectstore/lvmbluestore.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,8 @@ def setup_device(self,
249249
tags['ceph.%s_uuid' % device_type] = lv_uuid
250250
tags['ceph.%s_device' % device_type] = path
251251
lv.set_tags(tags)
252-
elif disk.is_device(device_name):
253-
# We got a disk, create an lv
252+
elif disk.is_partition(device_name) or disk.is_device(device_name):
253+
# We got a disk or a partition, create an lv
254254
lv_type = "osd-{}".format(device_type)
255255
name_uuid = system.generate_uuid()
256256
kwargs = {

0 commit comments

Comments
 (0)