Commit 1841c41
committed
python-common: fix mypy failure in NVMEoF service spec
Locally, mypy was complaining
```
ceph/deployment/service_spec.py: note: In member "validate" of class "NvmeofServiceSpec":
ceph/deployment/service_spec.py:1497: error: Unsupported operand types for > ("float" and "None") [operator]
ceph/deployment/service_spec.py:1497: note: Left operand is of type "Optional[float]"
ceph/deployment/service_spec.py:1500: error: Unsupported operand types for > ("int" and "None") [operator]
ceph/deployment/service_spec.py:1500: note: Left operand is of type "Optional[int]"
```
I'm unsure why those errors didn't show up in the CI,
but they make sense to me, so why not fix them.
Signed-off-by: Adam King <adking@redhat.com>1 parent 0089536 commit 1841c41
1 file changed
+8
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1494 | 1494 | | |
1495 | 1495 | | |
1496 | 1496 | | |
1497 | | - | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
1498 | 1501 | | |
1499 | 1502 | | |
1500 | | - | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
| 1506 | + | |
1501 | 1507 | | |
1502 | 1508 | | |
1503 | 1509 | | |
| |||
0 commit comments