Skip to content

Commit 19399de

Browse files
committed
mgr/cephadm: add SPDK log level to nvmeof configuration
Fixes https://tracker.ceph.com/issues/67258 Signed-off-by: Gil Bregman <[email protected]>
1 parent d3cc237 commit 19399de

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/pybind/mgr/cephadm/services/nvmeof.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def prepare_create(self, daemon_spec: CephadmDaemonDeploySpec) -> CephadmDaemonD
5252
'name': name,
5353
'addr': host_ip,
5454
'port': spec.port,
55-
'spdk_log_level': 'WARNING',
55+
'spdk_protocol_log_level': 'WARNING',
5656
'rpc_socket_dir': '/var/tmp/',
5757
'rpc_socket_name': 'spdk.sock',
5858
'transport_tcp_options': transport_tcp_options,

src/pybind/mgr/cephadm/templates/services/nvmeof/ceph-nvmeof.conf.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ omap_file_lock_retry_sleep_interval = {{ spec.omap_file_lock_retry_sleep_interva
1818
omap_file_update_reloads = {{ spec.omap_file_update_reloads }}
1919
allowed_consecutive_spdk_ping_failures = {{ spec.allowed_consecutive_spdk_ping_failures }}
2020
spdk_ping_interval_in_seconds = {{ spec.spdk_ping_interval_in_seconds }}
21-
ping_spdk_under_lock = {{ spec.ping_spdk_under_lock }}
2221
enable_monitor_client = {{ spec.enable_monitor_client }}
2322

2423
[gateway-logs]
@@ -53,7 +52,8 @@ rpc_socket_dir = {{ spec.rpc_socket_dir }}
5352
rpc_socket_name = {{ spec.rpc_socket_name }}
5453
timeout = {{ spec.spdk_timeout }}
5554
bdevs_per_cluster = {{ spec.bdevs_per_cluster }}
56-
log_level = {{ spec.spdk_log_level }}
55+
log_level={{ spec.spdk_log_level }}
56+
protocol_log_level = {{ spec.spdk_protocol_log_level }}
5757
conn_retries = {{ spec.conn_retries }}
5858
transports = {{ spec.transports }}
5959
{% if transport_tcp_options %}

src/pybind/mgr/cephadm/tests/test_services.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,6 @@ def test_nvmeof_config(self, _get_name, _run_cephadm, cephadm_module: CephadmOrc
404404
omap_file_update_reloads = 10
405405
allowed_consecutive_spdk_ping_failures = 1
406406
spdk_ping_interval_in_seconds = 2.0
407-
ping_spdk_under_lock = False
408407
enable_monitor_client = True
409408
410409
[gateway-logs]
@@ -439,7 +438,8 @@ def test_nvmeof_config(self, _get_name, _run_cephadm, cephadm_module: CephadmOrc
439438
rpc_socket_name = spdk.sock
440439
timeout = 60.0
441440
bdevs_per_cluster = 32
442-
log_level = WARNING
441+
log_level=
442+
protocol_log_level = WARNING
443443
conn_retries = 10
444444
transports = tcp
445445
transport_tcp_options = {{"in_capsule_data_size": 8192, "max_io_qpairs_per_ctrlr": 7}}

0 commit comments

Comments
 (0)