Merge pull request ceph#54148 from ivoalmeida/fix-edit-user-bucket-quota

Pegonzal · web-flow · commit 241e46afbbba · 2023-10-24T11:43:15.000+02:00
mgr/dashboard: fixed edit user quota form error

Reviewed-by: Ankush Behl &lt;cloudbehl@gmail.com&gt;
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/forms/cd-form-group.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/forms/cd-form-group.ts
@@ -68,7 +68,7 @@ export class CdFormGroup extends UntypedFormGroup {
   showError(controlName: string, form: NgForm, errorName?: string): boolean {
     const control = this.get(controlName);
     return (
-      (form.submitted || control.dirty) &&
+      (form?.submitted || control.dirty) &&
       (errorName ? control.hasError(errorName) : control.invalid)
     );
   }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ export class CdFormGroup extends UntypedFormGroup {`
`68`	`68`	`showError(controlName: string, form: NgForm, errorName?: string): boolean {`
`69`	`69`	`const control = this.get(controlName);`
`70`	`70`	`return (`
`71`		`- (form.submitted \|\| control.dirty) &&`
	`71`	`+ (form?.submitted \|\| control.dirty) &&`
`72`	`72`	`(errorName ? control.hasError(errorName) : control.invalid)`
`73`	`73`	`);`
`74`	`74`	`}`