crimson/os/seastore/transaction_manager: link RetiredExtentPlaceholder

onto lba leaf nodes

Signed-off-by: Xuehan Xu <[email protected]>

Author: xxhdx1985126

src/crimson/os/seastore/cache.cc

@@ -93,8 +93,8 @@ Cache::retire_extent_ret Cache::retire_extent_addr(
   return retire_extent_iertr::now();
 }
 
-void Cache::retire_absent_extent_addr(
-  Transaction &t, paddr_t paddr, extent_len_t length)
+CachedExtentRef Cache::retire_absent_extent_addr(
+  Transaction &t, laddr_t laddr, paddr_t paddr, extent_len_t length)
 {
   assert(paddr.is_absolute());
 
@@ -112,10 +112,12 @@ void Cache::retire_absent_extent_addr(
   ext->init(
     CachedExtent::extent_state_t::CLEAN, paddr,
     PLACEMENT_HINT_NULL, NULL_GENERATION, TRANS_ID_NULL);
+  static_cast<RetiredExtentPlaceholder&>(*ext).set_laddr(laddr);
   DEBUGT("retire {}~0x{:x} as placeholder, add extent -- {}",
 	 t, paddr, length, *ext);
   add_extent(ext);
   t.add_absent_to_retired_set(ext);
+  return ext;
 }
 
 void Cache::dump_contents()

src/crimson/os/seastore/cache.h

@@ -163,8 +163,8 @@ class Cache : public ExtentTransViewRetriever {
   retire_extent_ret retire_extent_addr(
     Transaction &t, paddr_t addr, extent_len_t length);
 
-  void retire_absent_extent_addr(
-    Transaction &t, paddr_t addr, extent_len_t length);
+  CachedExtentRef retire_absent_extent_addr(
+    Transaction &t, laddr_t laddr, paddr_t addr, extent_len_t length);
 
   /**
    * get_root

src/crimson/os/seastore/cached_extent.h

@@ -1366,54 +1366,6 @@ class ExtentIndex {
   uint64_t bytes = 0;
 };
 
-/**
- * RetiredExtentPlaceholder
- *
- * Cache::retire_extent_addr(Transaction&, paddr_t, extent_len_t) can retire an
- * extent not currently in cache. In that case, in order to detect transaction
- * invalidation, we need to add a placeholder to the cache to create the
- * mapping back to the transaction. And whenever there is a transaction tries
- * to read the placeholder extent out, Cache is responsible to replace the
- * placeholder by the real one. Anyway, No placeholder extents should escape
- * the Cache interface boundary.
- */
-class RetiredExtentPlaceholder : public CachedExtent {
-
-public:
-  RetiredExtentPlaceholder(extent_len_t length)
-    : CachedExtent(CachedExtent::retired_placeholder_construct_t{}, length) {}
-
-  CachedExtentRef duplicate_for_write(Transaction&) final {
-    ceph_abort_msg("Should never happen for a placeholder");
-    return CachedExtentRef();
-  }
-
-  ceph::bufferlist get_delta() final {
-    ceph_abort_msg("Should never happen for a placeholder");
-    return ceph::bufferlist();
-  }
-
-  static constexpr extent_types_t TYPE = extent_types_t::RETIRED_PLACEHOLDER;
-  extent_types_t get_type() const final {
-    return TYPE;
-  }
-
-  void apply_delta_and_adjust_crc(
-    paddr_t base, const ceph::bufferlist &bl) final {
-    ceph_abort_msg("Should never happen for a placeholder");
-  }
-
-  void on_rewrite(Transaction &, CachedExtent&, extent_len_t) final {}
-
-  std::ostream &print_detail(std::ostream &out) const final {
-    return out << ", RetiredExtentPlaceholder";
-  }
-
-  void on_delta_write(paddr_t record_block_offset) final {
-    ceph_abort_msg("Should never happen for a placeholder");
-  }
-};
-
 class LBAMapping;
 /**
  * LogicalCachedExtent

src/crimson/os/seastore/logical_child_node.h

@@ -10,6 +10,83 @@
 
 namespace crimson::os::seastore {
 
+/**
+ * RetiredExtentPlaceholder
+ *
+ * Cache::retire_extent_addr(Transaction&, paddr_t, extent_len_t) can retire an
+ * extent not currently in cache. In that case, in order to detect transaction
+ * invalidation, we need to add a placeholder to the cache to create the
+ * mapping back to the transaction. And whenever there is a transaction tries
+ * to read the placeholder extent out, Cache is responsible to replace the
+ * placeholder by the real one. Anyway, No placeholder extents should escape
+ * the Cache interface boundary.
+ */
+class RetiredExtentPlaceholder
+  : public CachedExtent,
+    public ChildNode<lba::LBALeafNode, RetiredExtentPlaceholder, laddr_t> {
+
+public:
+  RetiredExtentPlaceholder(extent_len_t length)
+    : CachedExtent(CachedExtent::retired_placeholder_construct_t{}, length) {}
+
+  ~RetiredExtentPlaceholder() {
+    if (this->is_stable()) {
+      lba_child_node_t::destroy();
+    }
+  }
+
+  CachedExtentRef duplicate_for_write(Transaction&) final {
+    ceph_abort_msg("Should never happen for a placeholder");
+    return CachedExtentRef();
+  }
+
+  ceph::bufferlist get_delta() final {
+    ceph_abort_msg("Should never happen for a placeholder");
+    return ceph::bufferlist();
+  }
+
+  static constexpr extent_types_t TYPE = extent_types_t::RETIRED_PLACEHOLDER;
+  extent_types_t get_type() const final {
+    return TYPE;
+  }
+
+  void apply_delta_and_adjust_crc(
+    paddr_t base, const ceph::bufferlist &bl) final {
+    ceph_abort_msg("Should never happen for a placeholder");
+  }
+
+  void on_rewrite(Transaction &, CachedExtent&, extent_len_t) final {}
+
+  std::ostream &print_detail(std::ostream &out) const final {
+    return out << ", RetiredExtentPlaceholder";
+  }
+
+  void on_delta_write(paddr_t record_block_offset) final {
+    ceph_abort_msg("Should never happen for a placeholder");
+  }
+
+  void set_laddr(laddr_t laddr) {
+    this->laddr = laddr;
+  }
+
+  bool is_btree_root() const {
+    return false;
+  }
+
+  laddr_t get_begin() const {
+    assert(laddr != L_ADDR_NULL);
+    return laddr;
+  }
+
+  laddr_t get_end() const {
+    assert(laddr != L_ADDR_NULL);
+    return (laddr + get_length()).checked_to_laddr();
+  }
+
+private:
+  laddr_t laddr = L_ADDR_NULL;
+};
+
 class LogicalChildNode : public LogicalCachedExtent,
 			 public ChildNode<lba::LBALeafNode,
 					  LogicalChildNode,