Skip to content

Commit 25cac0f

Browse files
committed
erasure-code/lrc: Change LRC default plugin from Jerasure to ISA
Signed-off-by: Jamie Pryde <[email protected]>
1 parent 4d3adb5 commit 25cac0f

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

doc/rados/operations/erasure-code-lrc.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
Locally repairable erasure code plugin
33
======================================
44

5-
With the *jerasure* plugin, when an erasure coded object is stored on
5+
With the *isa* plugin, when an erasure coded object is stored on
66
multiple OSDs, recovering from the loss of one OSD requires reading
7-
from *k* others. For instance if *jerasure* is configured with
7+
from *k* others. For instance if *isa* is configured with
88
*k=8* and *m=4*, recovering from the loss of one OSD requires reading
99
from eight others.
1010

@@ -195,7 +195,7 @@ Minimal testing
195195
---------------
196196

197197
It is strictly equivalent to using a *K=2* *M=1* erasure code profile. The *DD*
198-
implies *K=2*, the *c* implies *M=1* and the *jerasure* plugin is used
198+
implies *K=2*, the *c* implies *M=1* and the *isa* plugin is used
199199
by default.:
200200

201201
.. prompt:: bash $
@@ -253,19 +253,19 @@ the same rack as the lost chunk. **WARNING: PROMPTS ARE SELECTABLE**
253253
Testing with different Erasure Code backends
254254
--------------------------------------------
255255

256-
LRC now uses jerasure as the default EC backend. It is possible to
256+
LRC now uses ISA as the default EC backend. It is possible to
257257
specify the EC backend/algorithm on a per layer basis using the low
258258
level configuration. The second argument in layers='[ [ "DDc", "" ] ]'
259259
is actually an erasure code profile to be used for this level. The
260-
example below specifies the ISA backend with the cauchy technique to
260+
example below specifies the Jerasure backend with the cauchy technique to
261261
be used in the lrcpool.:
262262

263263
.. prompt:: bash $
264264

265265
ceph osd erasure-code-profile set LRCprofile \
266266
plugin=lrc \
267267
mapping=DD_ \
268-
layers='[ [ "DDc", "plugin=isa technique=cauchy" ] ]'
268+
layers='[ [ "DDc", "plugin=jerasure technique=cauchy" ] ]'
269269
ceph osd pool create lrcpool erasure LRCprofile
270270

271271
You could also use a different erasure code profile for each

src/erasure-code/lrc/ErasureCodeLrc.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
* version 2.1 of the License, or (at your option) any later version.
1515
*
1616
*/
17-
1817
#include <cerrno>
1918
#include <algorithm>
2019

@@ -232,7 +231,7 @@ int ErasureCodeLrc::layers_init(ostream *ss)
232231
if (layer.profile.find("m") == layer.profile.end())
233232
layer.profile["m"] = stringify(layer.coding.size());
234233
if (layer.profile.find("plugin") == layer.profile.end())
235-
layer.profile["plugin"] = "jerasure";
234+
layer.profile["plugin"] = "isa";
236235
if (layer.profile.find("technique") == layer.profile.end())
237236
layer.profile["technique"] = "reed_sol_van";
238237
int err = registry.factory(layer.profile["plugin"],

src/test/erasure-code/TestErasureCodeLrc.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ TEST(ErasureCodeLrc, layers_init)
417417
EXPECT_EQ(0, lrc.layers_init(&cerr));
418418
EXPECT_EQ("5", lrc.layers.front().profile["k"]);
419419
EXPECT_EQ("2", lrc.layers.front().profile["m"]);
420-
EXPECT_EQ("jerasure", lrc.layers.front().profile["plugin"]);
420+
EXPECT_EQ("isa", lrc.layers.front().profile["plugin"]);
421421
EXPECT_EQ("reed_sol_van", lrc.layers.front().profile["technique"]);
422422
}
423423
}

0 commit comments

Comments
 (0)