crimson/.../lba_btree_node: add assertion for pivot_idx validity

kep-chaney-p · kep-chaney-p · commit 271cf4f24c1d · 2025-07-29T16:10:04.000Z
Signed-off-by: Chanyoung Park &lt;chaney.p@kakaoenterprise.com&gt;
diff --git a/src/crimson/os/seastore/lba/lba_btree_node.h b/src/crimson/os/seastore/lba/lba_btree_node.h
@@ -259,6 +259,8 @@ struct LBALeafNode
     uint32_t pivot_idx,
     LBALeafNode &replacement_left,
     LBALeafNode &replacement_right) final {
+    // We should do full merge if pivot_idx == right.get_size().
+    ceph_assert(pivot_idx != right.get_size());
     this->balance_child_ptrs(
       t, left, right, pivot_idx, replacement_left, replacement_right);
   }

Original file line number	Diff line number	Diff line change
`@@ -259,6 +259,8 @@ struct LBALeafNode`
`259`	`259`	`uint32_t pivot_idx,`
`260`	`260`	`LBALeafNode &replacement_left,`
`261`	`261`	`LBALeafNode &replacement_right) final {`
	`262`	`+ // We should do full merge if pivot_idx == right.get_size().`
	`263`	`+ ceph_assert(pivot_idx != right.get_size());`
`262`	`264`	`this->balance_child_ptrs(`
`263`	`265`	`t, left, right, pivot_idx, replacement_left, replacement_right);`
`264`	`266`	`}`