test/crimson/seastore/test_seastore.cc: should not return a value

Matan-B · Matan-B · commit 28a7ee812800 · 2024-07-09T16:33:45.000Z
clang++-14:

```
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/crimson/seastore/test_seastore.cc:86:5: error: void function 'do_transaction' should not return a value [-Wreturn-type]
    return sharded_seastore-&gt;do_transaction(
    ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/crimson/seastore/test_seastore.cc:94:5: error: void function 'set_meta' should not return a value [-Wreturn-type]
    return seastore-&gt;write_meta(key, value).get();
    ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.
```

Signed-off-by: Matan Breizman &lt;mbreizma@redhat.com&gt;
diff --git a/src/test/crimson/seastore/test_seastore.cc b/src/test/crimson/seastore/test_seastore.cc
@@ -83,15 +83,15 @@ struct seastore_test_t :
   }
 
   void do_transaction(CTransaction &&t) {
-    return sharded_seastore->do_transaction(
+    return (void)sharded_seastore->do_transaction(
       coll,
       std::move(t)).get();
   }
 
   void set_meta(
     const std::string& key,
     const std::string& value) {
-    return seastore->write_meta(key, value).get();
+    return (void)seastore->write_meta(key, value).get();
   }
 
   std::tuple<int, std::string> get_meta(

Original file line number	Diff line number	Diff line change
`@@ -83,15 +83,15 @@ struct seastore_test_t :`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`void do_transaction(CTransaction &&t) {`
`86`		`- return sharded_seastore->do_transaction(`
	`86`	`+ return (void)sharded_seastore->do_transaction(`
`87`	`87`	`coll,`
`88`	`88`	`std::move(t)).get();`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`void set_meta(`
`92`	`92`	`const std::string& key,`
`93`	`93`	`const std::string& value) {`
`94`		`- return seastore->write_meta(key, value).get();`
	`94`	`+ return (void)seastore->write_meta(key, value).get();`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`std::tuple<int, std::string> get_meta(`