Skip to content

Commit 2d24819

Browse files
committed
mgr/cephadm: fix staggered upgrade daemon type warning
This was meant to just be daemons that use the ceph image, which everything under "gateway" daemons used to be before the addition of nvmeof and smb. This patch updates it to explicitly reference the daemon types that use the ceph image. Signed-off-by: Adam King <[email protected]>
1 parent 9564bd8 commit 2d24819

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/pybind/mgr/cephadm/module.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
from .upgrade import CephadmUpgrade
9898
from .template import TemplateMgr
9999
from .utils import CEPH_IMAGE_TYPES, RESCHEDULE_FROM_OFFLINE_HOSTS_TYPES, forall_hosts, \
100-
cephadmNoImage, CEPH_UPGRADE_ORDER, SpecialHostLabels
100+
cephadmNoImage, SpecialHostLabels
101101
from .configchecks import CephadmConfigChecks
102102
from .offline_watcher import OfflineHostWatcher
103103
from .tuned_profiles import TunedProfileUtils
@@ -3913,9 +3913,9 @@ def upgrade_start(self, image: str, version: str, daemon_types: Optional[List[st
39133913
raise OrchestratorError('--daemon-types and --services are mutually exclusive')
39143914
if daemon_types is not None:
39153915
for dtype in daemon_types:
3916-
if dtype not in CEPH_UPGRADE_ORDER:
3916+
if dtype not in utils.CEPH_IMAGE_TYPES:
39173917
raise OrchestratorError(f'Upgrade aborted - Got unexpected daemon type "{dtype}".\n'
3918-
f'Viable daemon types for this command are: {utils.CEPH_TYPES + utils.GATEWAY_TYPES}')
3918+
f'Viable daemon types for this command are: {utils.CEPH_IMAGE_TYPES}')
39193919
if services is not None:
39203920
for service in services:
39213921
if service not in self.spec_store:

0 commit comments

Comments
 (0)