Merge PR ceph#65715 into main

* refs/pull/65715/head:
	common/compat: resolve signedness warnings
	common/compat: resolve unused label warnings

Reviewed-by: Edwin Rodriguez <[email protected]>

Author: batrick

.githubmap

@@ -201,3 +201,4 @@ Shwetha-Acharya Shwetha Acharya <[email protected]>
 xhernandez Xavi Hernandez <[email protected]>
 ThomasLamprecht Thomas Lamprecht <[email protected]>
 jmundack Joseph Mundackal <[email protected]>
+edwinzrodriguez Edwin Rodriguez <[email protected]>

src/common/compat.cc

@@ -118,7 +118,9 @@ int pipe_cloexec(int pipefd[2], int flags)
   if (pipe(pipefd) == -1)
     return -1;
 
-  #ifndef _WIN32
+#  ifdef _WIN32
+  return 0;
+#  else
   /*
    * The old-fashioned, race-condition prone way that we have to fall
    * back on if pipe2 does not exist.
@@ -130,14 +132,15 @@ int pipe_cloexec(int pipefd[2], int flags)
   if (fcntl(pipefd[1], F_SETFD, FD_CLOEXEC) < 0) {
     goto fail;
   }
-  #endif
 
   return 0;
+
 fail:
   int save_errno = errno;
   VOID_TEMP_FAILURE_RETRY(close(pipefd[0]));
   VOID_TEMP_FAILURE_RETRY(close(pipefd[1]));
   return (errno = save_errno, -1);
+#  endif
 #endif
 }
 
@@ -151,16 +154,17 @@ int socket_cloexec(int domain, int type, int protocol)
   if (fd == -1)
     return -1;
 
-  #ifndef _WIN32
+#  ifdef _WIN32
+  return fd;
+#  else
   if (fcntl(fd, F_SETFD, FD_CLOEXEC) < 0)
     goto fail;
-  #endif
-
   return fd;
 fail:
   int save_errno = errno;
   VOID_TEMP_FAILURE_RETRY(close(fd));
   return (errno = save_errno, -1);
+#  endif
 #endif
 }
 
@@ -202,16 +206,18 @@ int accept_cloexec(int sockfd, struct sockaddr* addr, socklen_t* addrlen)
   if (fd == -1)
     return -1;
 
-  #ifndef _WIN32
+#  ifdef _WIN32
+  return fd;
+#  else
   if (fcntl(fd, F_SETFD, FD_CLOEXEC) < 0)
     goto fail;
-  #endif
 
   return fd;
 fail:
   int save_errno = errno;
   VOID_TEMP_FAILURE_RETRY(close(fd));
   return (errno = save_errno, -1);
+#  endif
 #endif
 }
 
@@ -363,7 +369,7 @@ ssize_t preadv(int fd, const struct iovec *iov, int iov_cnt) {
     if (r < 0)
       return r;
     read += r;
-    if (r < iov[i].iov_len)
+    if ((unsigned)r < iov[i].iov_len)
       break;
   }
 
@@ -378,7 +384,7 @@ ssize_t writev(int fd, const struct iovec *iov, int iov_cnt) {
     if (r < 0)
       return r;
     written += r;
-    if (r < iov[i].iov_len)
+    if ((unsigned)r < iov[i].iov_len)
       break;
   }