Skip to content

Commit 4010045

Browse files
committed
crimson/os/seastore/lba_manager: rename clone_extent to clone_mapping
Signed-off-by: Xuehan Xu <[email protected]>
1 parent 231c7ac commit 4010045

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/crimson/os/seastore/lba_manager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class LBAManager {
8989
paddr_t addr,
9090
LogicalCachedExtent &nextent) = 0;
9191

92-
virtual alloc_extent_ret clone_extent(
92+
virtual alloc_extent_ret clone_mapping(
9393
Transaction &t,
9494
laddr_t hint,
9595
extent_len_t len,

src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ class BtreeLBAManager : public LBAManager {
220220
nullptr);
221221
}
222222

223-
alloc_extent_ret clone_extent(
223+
alloc_extent_ret clone_mapping(
224224
Transaction &t,
225225
laddr_t hint,
226226
extent_len_t len,

src/crimson/os/seastore/transaction_manager.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -485,12 +485,12 @@ class TransactionManager : public ExtentCallbackInterface {
485485
}
486486

487487
/*
488-
* clone_pin
488+
* clone_mapping
489489
*
490490
* create an indirect lba mapping pointing to the physical
491491
* lba mapping whose key is intermediate_key. Resort to btree_lba_manager.h
492-
* for the definition of "indirect lba mapping" and "physical lba mapping"
493-
*
492+
* for the definition of "indirect lba mapping" and "physical lba mapping".
493+
* Note that the cloned extent must be stable
494494
*/
495495
using clone_extent_iertr = alloc_extent_iertr;
496496
using clone_extent_ret = clone_extent_iertr::future<LBAMappingRef>;
@@ -507,7 +507,7 @@ class TransactionManager : public ExtentCallbackInterface {
507507
SUBDEBUGT(seastore_tm, "len={}, laddr_hint={}, clone_offset {}",
508508
t, mapping.get_length(), hint, intermediate_key);
509509
ceph_assert(is_aligned(hint, epm->get_block_size()));
510-
return lba_manager->clone_extent(
510+
return lba_manager->clone_mapping(
511511
t,
512512
hint,
513513
mapping.get_length(),
@@ -887,7 +887,7 @@ class TransactionManager : public ExtentCallbackInterface {
887887
fut = lba_manager->alloc_extent(
888888
t, remap_laddr, remap_length, remap_paddr, *ext);
889889
} else {
890-
fut = lba_manager->clone_extent(
890+
fut = lba_manager->clone_mapping(
891891
t,
892892
remap_laddr,
893893
remap_length,

0 commit comments

Comments
 (0)