Merge pull request ceph#58062 from rhcs-dashboard/cephadm-flake8-fix

mgr/cephadm: fix flake8 test failures

Reviewed-by: Ilya Dryomov <[email protected]>

Author: idryomov

src/pybind/mgr/cephadm/configchecks.py

@@ -91,7 +91,7 @@ def __init__(self, subnet: str, hostname: str, mtu: str, speed: str):
             speed: [hostname]
         }
 
-    @ property
+    @property
     def host_list(self) -> List[str]:
         hosts = []
         for mtu in self.mtu_map:

src/pybind/mgr/cephadm/module.py

@@ -3014,7 +3014,7 @@ def _create_daemons(self,
             )
             daemons.append(sd)
 
-        @ forall_hosts
+        @forall_hosts
         def create_func_map(*args: Any) -> str:
             daemon_spec = self.cephadm_services[daemon_type].prepare_create(*args)
             with self.async_timeout_handler(daemon_spec.host, f'cephadm deploy ({daemon_spec.daemon_type} daemon)'):
@@ -3341,7 +3341,7 @@ def _apply_service_spec(self, spec: ServiceSpec) -> str:
                         (f'The maximum number of {spec.service_type} daemons allowed with {host_count} hosts is {max(5, host_count)}.'))
             elif spec.service_type != 'osd':
                 if spec.placement.count > (max_count * host_count):
-                    raise OrchestratorError((f'The maximum number of {spec.service_type} daemons allowed with {host_count} hosts is {host_count*max_count} ({host_count}x{max_count}).'
+                    raise OrchestratorError((f'The maximum number of {spec.service_type} daemons allowed with {host_count} hosts is {host_count * max_count} ({host_count}x{max_count}).'
                                              + ' This limit can be adjusted by changing the mgr/cephadm/max_count_per_host config option'))
 
         if spec.placement.count_per_host is not None and spec.placement.count_per_host > max_count and spec.service_type != 'osd':

src/pybind/mgr/cephadm/tests/test_cephadm.py

@@ -979,7 +979,7 @@ def test_find_destroyed_osds(self, _mon_cmd, cephadm_module):
         assert osd_claims.filtered_by_host('host1') == ['0']
         assert osd_claims.filtered_by_host('host1.domain.com') == ['0']
 
-    @ pytest.mark.parametrize(
+    @pytest.mark.parametrize(
         "ceph_services, cephadm_daemons, strays_expected, metadata",
         # [ ([(daemon_type, daemon_id), ... ], [...], [...]), ... ]
         [