Merge pull request ceph#62672 from adamemerson/wip-test-common-signed-comparison

yuriw · web-flow · commit 48d88f2d2ba1 · 2025-04-29T07:55:58.000-07:00
test/common: Fix signed comparison

Reviewed-by: Kefu Chai &lt;tchaikov@gmail.com&gt;
diff --git a/src/test/common/test_hobject.cc b/src/test/common/test_hobject.cc
@@ -285,7 +285,7 @@ TEST(HObject, fmt_random)
 
     auto name_length = (i * 17) % 51;
     std::string name;
-    for (int j = 0; j < name_length; j++) {
+    for (int j = 0; std::cmp_less(j, name_length); j++) {
       name.push_back((i * name_length + j) % 256);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,7 @@ TEST(HObject, fmt_random)`
`285`	`285`
`286`	`286`	`auto name_length = (i * 17) % 51;`
`287`	`287`	`std::string name;`
`288`		`- for (int j = 0; j < name_length; j++) {`
	`288`	`+ for (int j = 0; std::cmp_less(j, name_length); j++) {`
`289`	`289`	`name.push_back((i * name_length + j) % 256);`
`290`	`290`	`}`
`291`	`291`