Merge pull request ceph#64262 from Matan-B/wip-matanb-crimson-abort-msg

crimson: switch to ceph_abort_msg

Reviewed-by: Yingxin Cheng <[email protected]>

Author: Matan-B

src/crimson/net/FrameAssemblerV2.cc

@@ -427,7 +427,7 @@ FrameAssemblerV2::read_frame_payload()
     // and abort after putting entire data field on wire. This will be used by
     // the kernel client to avoid unnecessary buffering.
     if (!ok) {
-      ceph_abort("TODO");
+      ceph_abort_msg("TODO");
     }
     return &rx_segments_data;
   });

src/crimson/net/Interceptor.h

@@ -79,7 +79,7 @@ class socket_blocker {
       return seastar::sleep_abortable(
         std::chrono::seconds(10), *p_unblocked
       ).then([] {
-        ceph_abort("Timeout (10s) in socket_blocker::block()");
+        ceph_abort_msg("Timeout (10s) in socket_blocker::block()");
       }).handle_exception_type([] (const seastar::sleep_aborted& e) {
         // wait done!
       });

src/crimson/net/ProtocolV2.cc

@@ -908,7 +908,7 @@ void ProtocolV2::execute_connecting()
           logger().info("[Test] got BLOCK");
           return conn.interceptor->blocker.block();
         default:
-          ceph_abort("unexpected action from trap");
+          ceph_abort_msg("unexpected action from trap");
           return seastar::now();
         }
       });;
@@ -1041,7 +1041,7 @@ void ProtocolV2::execute_connecting()
         return seastar::now();
        }
        default: {
-        ceph_abort("impossible next step");
+        ceph_abort_msg("impossible next step");
        }
       }
     }).handle_exception([this](std::exception_ptr eptr) {
@@ -1693,7 +1693,7 @@ void ProtocolV2::execute_accepting()
         execute_server_wait();
         break;
        default:
-        ceph_abort("impossible next step");
+        ceph_abort_msg("impossible next step");
       }
     }).handle_exception([this](std::exception_ptr eptr) {
       const char *e_what;

src/crimson/net/Socket.cc

@@ -332,7 +332,7 @@ Socket::try_trap_pre(bp_action_t& trap) {
     trap = action;
     break;
    default:
-    ceph_abort("unexpected action from trap");
+    ceph_abort_msg("unexpected action from trap");
   }
   return seastar::make_ready_future<>();
 }
@@ -349,7 +349,7 @@ Socket::try_trap_post(bp_action_t& trap) {
     force_shutdown();
     return blocker->block();
    default:
-    ceph_abort("unexpected action from trap");
+    ceph_abort_msg("unexpected action from trap");
   }
   return seastar::make_ready_future<>();
 }

src/crimson/net/io_handler.cc

@@ -912,7 +912,7 @@ IOHandler::do_out_dispatch(shard_states_t &ctx)
       ctx.exit_out_dispatching("switched", conn);
       return seastar::make_ready_future<stop_t>(stop_t::yes);
      default:
-      ceph_abort("impossible");
+      ceph_abort_msg("impossible");
     }
   }).handle_exception_type([this, &ctx](const std::system_error& e) {
     auto io_state = ctx.get_io_state();
@@ -1130,7 +1130,7 @@ void IOHandler::do_in_dispatch()
                 return seastar::now();
               }
               // TODO: message throttler
-              ceph_abort("TODO");
+              ceph_abort_msg("TODO");
               return seastar::now();
             }).then([this, msg_size] {
               // throttle_bytes() logic

src/crimson/net/io_handler.h

@@ -329,7 +329,7 @@ class IOHandler final : public ConnectionHandler {
         crimson::get_logger(ceph_subsys_ms).error(
           "{} try_enter_out_dispatching() got wrong io_state {}",
           conn, io_state);
-        ceph_abort("impossible");
+        ceph_abort_msg("impossible");
       }
     }
 

src/crimson/os/seastore/async_cleaner.cc

@@ -1075,7 +1075,7 @@ segment_id_t SegmentCleaner::allocate_segment(
   ERROR("out of space with {} {} {} {}",
         type, segment_seq_printer_t{seq}, category,
         rewrite_gen_printer_t{generation});
-  ceph_abort("seastore device size setting is too small");
+  ceph_abort_msg("seastore device size setting is too small");
   return NULL_SEG_ID;
 }
 
@@ -1703,7 +1703,7 @@ segment_id_t SegmentCleaner::get_next_reclaim_segment() const
   } else {
     ceph_assert(get_segments_reclaimable() == 0);
     // see should_clean_space()
-    ceph_abort("impossible!");
+    ceph_abort_msg("impossible!");
     return NULL_SEG_ID;
   }
 }

src/crimson/os/seastore/backref/btree_backref_manager.cc

@@ -216,7 +216,7 @@ BtreeBackrefManager::new_mapping(
                    t, addr, len, key,
                    pos.get_key(), pos.get_val().len,
                    pos.get_val());
-	    ceph_abort("not possible for the backref tree");
+	    ceph_abort_msg("not possible for the backref tree");
 	    return BackrefBtree::iterate_repeat_ret_inner(
 	      interruptible::ready_future_marker{},
 	      seastar::stop_iteration::no);

src/crimson/os/seastore/btree/fixed_kv_btree.h

@@ -707,7 +707,7 @@ class FixedKVBtree {
           }
         } else {
           ceph_assert(!child_node->is_valid());
-          ceph_abort("impossible");
+          ceph_abort_msg("impossible");
         }
       } else if (ret == Transaction::get_extent_ret::ABSENT) {
         BaseChildNode<std::remove_reference_t<decltype(*node)>,
@@ -751,7 +751,7 @@ class FixedKVBtree {
                   i->get_key())));
         }
       } else {
-        ceph_abort("impossible");
+        ceph_abort_msg("impossible");
       }
     }
   }

src/crimson/os/seastore/cache.cc

@@ -1237,7 +1237,7 @@ record_t Cache::prepare_record(
     if (!i.ref->is_valid()) {
       SUBERRORT(seastore_t,
           "read_set got invalid extent, aborting -- {}", t, *i.ref);
-      ceph_abort("no invalid extent allowed in transactions' read_set");
+      ceph_abort_msg("no invalid extent allowed in transactions' read_set");
     }
     get_by_ext(efforts.read_by_ext,
                i.ref->get_type()).increment(i.ref->get_length());
@@ -1424,7 +1424,7 @@ record_t Cache::prepare_record(
       remove_backref_extent(extent->get_paddr());
     } else {
       ERRORT("Got unexpected extent type: {}", t, *extent);
-      ceph_abort("imposible");
+      ceph_abort_msg("imposible");
     }
   }
   alloc_deltas.emplace_back(std::move(rel_delta));
@@ -1642,7 +1642,7 @@ record_t Cache::prepare_record(
       SUBINFOT(seastore_t, "alloc_tail all trimmed, set to head {}, src={}",
                t, alloc_tail, trans_src);
     } else if (*maybe_alloc_tail == JOURNAL_SEQ_NULL) {
-      ceph_abort("impossible");
+      ceph_abort_msg("impossible");
     } else {
       alloc_tail = *maybe_alloc_tail;
     }
@@ -1859,7 +1859,7 @@ void Cache::complete_commit(
 	  i->get_type());
     } else {
       ERRORT("{}", t, *i);
-      ceph_abort("not possible");
+      ceph_abort_msg("not possible");
     }
   });