Skip to content

Commit 4c3e443

Browse files
committed
mgr/dashboard: bump node to 20.18.1
one of the inner dependency expects it ``` npm WARN EBADENGINE Unsupported engine { npm WARN EBADENGINE package: '[email protected]', npm WARN EBADENGINE required: { node: '>=20.18.1' }, npm WARN EBADENGINE current: { node: 'v20.13.1', npm: '10.5.2' } npm WARN EBADENGINE } ``` Fixes: https://tracker.ceph.com/issues/70934 Signed-off-by: Nizamudeen A <[email protected]>
1 parent 0b6cf66 commit 4c3e443

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

doc/dev/developer_guide/dash-devel.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ The build process is based on `Node.js <https://nodejs.org/>`_ and requires the
211211
Prerequisites
212212
~~~~~~~~~~~~~
213213

214-
* Node 20.13.1 or higher
214+
* Node 20.18.1 or higher
215215
* NPM 10.5.2 or higher
216216

217217
nodeenv:

make-dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ build_dashboard_frontend() {
133133

134134
$CURR_DIR/src/tools/setup-virtualenv.sh $TEMP_DIR
135135
$TEMP_DIR/bin/pip install nodeenv
136-
$TEMP_DIR/bin/nodeenv --verbose -p --node=20.13.1
136+
$TEMP_DIR/bin/nodeenv --verbose -p --node=20.18.1
137137
cd src/pybind/mgr/dashboard/frontend
138138

139139
. $TEMP_DIR/bin/activate
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v20.13.1
1+
v20.18.1

src/pybind/mgr/dashboard/frontend/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ else(WITH_SYSTEM_NPM)
6464
OUTPUT "${mgr-dashboard-nodeenv-dir}/bin/npm"
6565
COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${MGR_PYTHON_EXECUTABLE} ${mgr-dashboard-nodeenv-dir}
6666
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/pip install nodeenv
67-
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=20.13.1
67+
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=20.18.1
6868
# ensure that the files that nodeenv unpacks from tarballs are owned by
6969
# the current user. This can be an issue due to the node tarball using
7070
# uid 1000 and running the unpack in a id-mapped namespace (container)

0 commit comments

Comments
 (0)