Skip to content

Commit 4f9a926

Browse files
committed
cephfs-journal-tool:: Don't reset the journal trim position
If the fs had to go through journal recovery and reset, the cephfs-journal-tool resets the journal trim position because of which the old unused journal objects just stay forever in the metadata pool. The patch fixes the issue. Now, the old stale journal objects are trimmed during the regular trimming cycle helping to recover space in the metadata pool. Fixes: https://tracker.ceph.com/issues/69708 Signed-off-by: Kotresh HR <[email protected]>
1 parent 7e85556 commit 4f9a926

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/tools/cephfs/Resetter.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ int Resetter::reset()
119119
journaler.set_read_pos(new_start);
120120
journaler.set_write_pos(new_start);
121121
journaler.set_expire_pos(new_start);
122-
journaler.set_trimmed_pos(new_start);
123122
journaler.set_writeable();
124123

125124
cout << "writing journal head" << std::endl;

0 commit comments

Comments
 (0)