Skip to content

Commit 51bda54

Browse files
committed
mgr/cephadm: add a new config option 'oob_default_addr'
So there's a default value (169.254.1.1) which is the default address for the 'OS to iDrac pass-through' interface. Given that node-proxy will reach the RedFish API through this interface, we can make users avoid to pass that addr when providing the host spec at bootstrap time. Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
1 parent c07482a commit 51bda54

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/pybind/mgr/cephadm/module.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -495,6 +495,12 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule,
495495
desc="Destination for cephadm command's persistent logging",
496496
enum_allowed=['file', 'syslog', 'file,syslog'],
497497
),
498+
Option(
499+
'oob_default_addr',
500+
type='str',
501+
default='169.254.1.1',
502+
desc="Default address for RedFish API (oob management)."
503+
),
498504
]
499505

500506
def __init__(self, *args: Any, **kwargs: Any):
@@ -579,6 +585,7 @@ def __init__(self, *args: Any, **kwargs: Any):
579585
self.log_refresh_metadata = False
580586
self.default_cephadm_command_timeout = 0
581587
self.cephadm_log_destination = ''
588+
self.oob_default_addr = ''
582589

583590
self.notify(NotifyType.mon_map, None)
584591
self.config_notify()
@@ -1631,7 +1638,7 @@ def _add_host(self, spec):
16311638

16321639
if spec.oob:
16331640
if not spec.oob.get('addr'):
1634-
spec.oob['addr'] = spec.hostname
1641+
spec.oob['addr'] = self.oob_default_addr
16351642
if not spec.oob.get('port'):
16361643
spec.oob['port'] = '443'
16371644
host_oob_info = dict()

0 commit comments

Comments
 (0)