Skip to content

Commit 56cb53d

Browse files
committed
LogMonitor: set no_reply for forward MLog commands
On streach mod clusters we can see slow ops when removing and adding osds with --zap --force when osds connected to peon monitor and forwarding the MLog to leader. the no_reply is set only when we are connected to the leader, this fix will add also the other option - so no_reply set anyway. Fixes: https://tracker.ceph.com/issues/54489 Signed-off-by: Nitzan Mordechai <[email protected]>
1 parent 8bc54ae commit 56cb53d

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/mon/LogMonitor.cc

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -711,11 +711,9 @@ bool LogMonitor::preprocess_log(MonOpRequestRef op)
711711
goto done;
712712
}
713713

714-
return false;
715-
716-
done:
717-
mon.no_reply(op);
718-
return true;
714+
done:
715+
mon.no_reply(op);
716+
return (!num_new);
719717
}
720718

721719
struct LogMonitor::C_Log : public C_MonOp {

0 commit comments

Comments
 (0)