Merge pull request ceph#60477 from VVoidV/lbr-ETAG-consistent-with-AWS

<rgw> Ensure the ETag format is consistent with AWS S3 API

Reviewed-by: Casey Bodley <[email protected]>

Author: cbodley

PendingReleaseNotes

@@ -16,6 +16,8 @@
   moving backwards as a result.
 * RGW: IAM policy evaluation now supports conditions ArnEquals and ArnLike, along
   with their Not and IfExists variants.
+* RGW: Adding missing quotes to the ETag values returned by S3 CopyPart,
+  PostObject and CompleteMultipartUpload responses.
 
 * RBD: All Python APIs that produce timestamps now return "aware" `datetime`
   objects instead of "naive" ones (i.e. those including time zone information

src/rgw/rgw_rest_s3.cc

@@ -2919,7 +2919,7 @@ void RGWPutObj_ObjStore_S3::send_response()
       if (strftime(buf, sizeof(buf), "%Y-%m-%dT%T.000Z", &tmp) > 0) {
         s->formatter->dump_string("LastModified", buf);
       }
-      s->formatter->dump_string("ETag", etag);
+      s->formatter->dump_format("ETag", "\"%s\"", etag.c_str());
       s->formatter->close_section();
       rgw_flush_formatter_and_reset(s, s->formatter);
       return;
@@ -3556,7 +3556,7 @@ void RGWPostObj_ObjStore_S3::send_response()
     }
     s->formatter->dump_string("Bucket", s->bucket_name);
     s->formatter->dump_string("Key", s->object->get_name());
-    s->formatter->dump_string("ETag", etag);
+    s->formatter->dump_format("ETag", "\"%s\"", etag.c_str());
     s->formatter->close_section();
   }
   s->err.message = err_msg;
@@ -4593,7 +4593,7 @@ void RGWCompleteMultipart_ObjStore_S3::send_response()
     }
     s->formatter->dump_string("Bucket", s->bucket_name);
     s->formatter->dump_string("Key", s->object->get_name());
-    s->formatter->dump_string("ETag", etag);
+    s->formatter->dump_format("ETag", "\"%s\"", etag.c_str());
     if (armored_cksum) [[likely]] {
       auto cksum_type
 	= rgw::cksum::get_checksum_type(*cksum, true /* is_multipart */);