Skip to content

Commit 5798d2f

Browse files
committed
mgr/dashboard: fix flaky promql query test
There is a test collision in "promql-query-test" test suite because two different IOPS panels with the same title and legend labels (Read, Write) are present, and the test framework is not able to distinguish between them. There are two panels with the same title IOPS and legends Read / Write, but different expressions:\ 1. ceph-application-overview.json 2. ceph-cluster-advanced.json Fixes: https://tracker.ceph.com/issues/71318 Signed-off-by: Aashish Sharma <[email protected]>
1 parent a3babf1 commit 5798d2f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

monitoring/ceph-mixin/dashboards_out/ceph-application-overview.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
},
3939
"id": 11,
4040
"panels": [],
41-
"title": "Application ($application)",
41+
"title": "Application (${application:csv})",
4242
"type": "row"
4343
},
4444
{
@@ -162,7 +162,7 @@
162162
"uid": "${datasource}"
163163
},
164164
"editorMode": "code",
165-
"expr": "Sum(rate(ceph_pool_wr{cluster=~\"$cluster\",}[$__rate_interval]) *\n on(pool_id) group_left(instance,name) ceph_pool_metadata{cluster=~\"$cluster\",name=~\"$pool\"})",
165+
"expr": "sum(rate(ceph_pool_wr{cluster=~\"$cluster\",}[$__rate_interval]) *\n on(pool_id) group_left(instance,name) ceph_pool_metadata{cluster=~\"$cluster\",name=~\"$pool\"})",
166166
"legendFormat": "Write",
167167
"range": true,
168168
"refId": "A"
@@ -173,14 +173,14 @@
173173
"uid": "${datasource}"
174174
},
175175
"editorMode": "code",
176-
"expr": "Sum(rate(ceph_pool_rd{cluster=~\"$cluster\",}[$__rate_interval]) *\n on(pool_id) group_left(instance,name) ceph_pool_metadata{cluster=~\"$cluster\",name=~\"$pool\"})",
176+
"expr": "sum(rate(ceph_pool_rd{cluster=~\"$cluster\",}[$__rate_interval]) *\n on(pool_id) group_left(instance,name) ceph_pool_metadata{cluster=~\"$cluster\",name=~\"$pool\"})",
177177
"hide": false,
178178
"legendFormat": "Read",
179179
"range": true,
180180
"refId": "B"
181181
}
182182
],
183-
"title": "IOPS",
183+
"title": "IOPS (${application:csv} - $pool)",
184184
"type": "stat"
185185
},
186186
{
@@ -361,7 +361,7 @@
361361
"refId": "B"
362362
}
363363
],
364-
"title": "Throughput",
364+
"title": "Throughput (${application:csv} - $pool)",
365365
"type": "stat"
366366
},
367367
{

0 commit comments

Comments
 (0)