Merge pull request ceph#63840 from tchaikov/wip-test-erasure-code-fix-leak

tchaikov · web-flow · commit 5b676c65d216 · 2025-06-12T08:10:07.000+08:00
test/erasure-code: fix memory leak in ErasureCodePlugin.parity_delta_…

Reviewed-by: Alex Ainscow &lt;aainscow@uk.ibm.com&gt;
diff --git a/src/test/erasure-code/TestErasureCodePluginJerasure.cc b/src/test/erasure-code/TestErasureCodePluginJerasure.cc
@@ -118,8 +118,7 @@ TEST(ErasureCodePlugin, parity_delta_write) {
     ASSERT_EQ(*(uint32_t*)coding[s].c_str(), *(uint32_t*)coding2[s].c_str());
   }
 
-  data.erase(shard_id_t(4));
-  data.emplace(shard_id_t(4), (char*)malloc(4096), 4096);
+  data[shard_id_t(4)] = create_bufferptr(4096);
   shard_id_set want;
   want.insert_range(shard_id_t(0), 5);
   decode_in[shard_id_t(0)] = data[shard_id_t(0)];

Original file line number	Diff line number	Diff line change
`@@ -118,8 +118,7 @@ TEST(ErasureCodePlugin, parity_delta_write) {`
`118`	`118`	`ASSERT_EQ((uint32_t)coding[s].c_str(), (uint32_t)coding2[s].c_str());`
`119`	`119`	`}`
`120`	`120`
`121`		`- data.erase(shard_id_t(4));`
`122`		`- data.emplace(shard_id_t(4), (char*)malloc(4096), 4096);`
	`121`	`+ data[shard_id_t(4)] = create_bufferptr(4096);`
`123`	`122`	`shard_id_set want;`
`124`	`123`	`want.insert_range(shard_id_t(0), 5);`
`125`	`124`	`decode_in[shard_id_t(0)] = data[shard_id_t(0)];`