Skip to content

Commit 5c738ba

Browse files
committed
crimson/common/fatal_signal: skip print_segv_info and proc_maps
Signed-off-by: Matan Breizman <[email protected]>
1 parent de2555e commit 5c738ba

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/crimson/common/fatal_signal.cc

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ void FatalSignal::install_oneshot_signal_handler()
110110
// see handle_fatal_signal()
111111
}
112112

113-
static void print_segv_info(const siginfo_t& siginfo)
113+
[[maybe_unused]] static void print_segv_info(const siginfo_t& siginfo)
114114
{
115115
std::cerr \
116116
<< "Dump of siginfo:" << std::endl
@@ -139,7 +139,7 @@ static void print_segv_info(const siginfo_t& siginfo)
139139
std::cerr << std::flush;
140140
}
141141

142-
static void print_proc_maps()
142+
[[maybe_unused]] static void print_proc_maps()
143143
{
144144
const int fd = ::open("/proc/self/maps", O_RDONLY);
145145
if (fd < 0) {
@@ -168,17 +168,20 @@ static void print_proc_maps()
168168
[[gnu::noinline]] void FatalSignal::signaled(const int signum,
169169
const siginfo_t& siginfo)
170170
{
171+
// Commented out for clean backtrace logs,
172+
// can be used if needed:
173+
// print_proc_maps();
174+
// print_segv_info(siginfo);
175+
171176
switch (signum) {
172177
case SIGSEGV:
173-
print_backtrace("Segmentation fault");
174-
print_segv_info(siginfo);
178+
print_backtrace("Got SIGSEGV");
175179
break;
176180
case SIGABRT:
177-
print_backtrace("Aborting");
181+
print_backtrace("Got SIGABRT");
178182
break;
179183
default:
180-
print_backtrace(fmt::format("Signal {}", signum));
184+
print_backtrace(fmt::format("Got signal {}", signum));
181185
break;
182186
}
183-
print_proc_maps();
184187
}

0 commit comments

Comments
 (0)