Merge PR ceph#56529 into main

* refs/pull/56529/head:
	mds: remove unnecssary quiesce finisher variable
	mds: attach quiesce_path mdr to finisher at creation not dispatch

Reviewed-by: Leonid Usov <[email protected]>

Author: batrick

src/mds/MDCache.cc

@@ -13766,6 +13766,7 @@ void MDCache::dispatch_quiesce_path(const MDRequestRef& mdr)
   dout(5) << __func__ << ": dispatching" << dendl;
 
   C_MDS_QuiescePath* qfinisher = static_cast<C_MDS_QuiescePath*>(mdr->internal_op_finish);
+  ceph_assert(qfinisher->mdr == mdr);
   auto& qs = *qfinisher->qs;
   auto delay = g_conf().get_val<std::chrono::milliseconds>("mds_cache_quiesce_delay");
   auto splitauth = g_conf().get_val<bool>("mds_cache_quiesce_splitauth");
@@ -13796,8 +13797,6 @@ void MDCache::dispatch_quiesce_path(const MDRequestRef& mdr)
     return;
   }
 
-  qfinisher->mdr = mdr;
-
   {
     int myrc = 0;
     for (auto& [qimdr, rc] : qs.get_failed()) {
@@ -13834,9 +13833,8 @@ void MDCache::dispatch_quiesce_path(const MDRequestRef& mdr)
   }
 
   if (qfinisher) {
-    auto* c = mdr->internal_op_finish;
     mdr->internal_op_finish = nullptr; // prevent ::request_kill recursion
-    c->complete(0);
+    qfinisher->complete(0);
   }
   mdr->result = 0;
 
@@ -13847,6 +13845,7 @@ MDRequestRef MDCache::quiesce_path(filepath p, C_MDS_QuiescePath* c, Formatter *
   MDRequestRef mdr = request_start_internal(CEPH_MDS_OP_QUIESCE_PATH);
   mdr->set_filepath(p);
   mdr->internal_op_finish = c;
+  c->mdr = mdr;
 
   if (delay > 0ms) {
     mds->timer.add_event_after(delay, new LambdaContext([cache=this,mdr=mdr](int r) {