mgr/smb: Use the default for minimum protocol version

'server min protocol' smb.conf option indicates the minimum SMB protocol
version that the server can support during client negotiation phase. We
can be generous in this case to accept various client implementations
with a subset of supported protocol versions. With 'SMB2' it selects the
highest available version from the list of sub protocols. Instead we
refrain from configuring the option to support the least possible SMB2
version by default(which is SMB2_02 at this point in time) from Samba.

ref: https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html
Signed-off-by: Anoop C S <[email protected]>

Author: anoopcs9

qa/suites/orch/cephadm/smb/tasks/deploy_smb_basic.yaml

@@ -52,7 +52,6 @@ tasks:
             "read only" = "no"
             "browseable" = "yes"
             [globals.default.options]
-            "server min protocol" = "SMB2"
             "load printers" = "no"
             "printing" = "bsd"
             "printcap name" = "/dev/null"

qa/suites/orch/cephadm/smb/tasks/deploy_smb_domain.yaml

@@ -51,7 +51,6 @@ tasks:
           "read only" = "no"
           "browseable" = "yes"
           [globals.default.options]
-          "server min protocol" = "SMB2"
           "load printers" = "no"
           "printing" = "bsd"
           "printcap name" = "/dev/null"

src/pybind/mgr/smb/handler.py

@@ -1069,7 +1069,6 @@ def _generate_config(
         'globals': {
             'default': {
                 'options': {
-                    'server min protocol': 'SMB2',
                     'load printers': 'No',
                     'printing': 'bsd',
                     'printcap name': '/dev/null',

src/pybind/mgr/smb/tests/test_smb.py

@@ -446,7 +446,6 @@ def test_share_dump_config(tmodule):
         'globals': {
             'default': {
                 'options': {
-                    'server min protocol': 'SMB2',
                     'load printers': 'No',
                     'printing': 'bsd',
                     'printcap name': '/dev/null',