Skip to content

Commit 655aedf

Browse files
committed
client: Fix parsing of xattr namespace in removexattr
To match the kernel ceph client, as mentioned by the inline comments, remove the comparison with "system." xattr namespace in removexattr() code path. This is in preparation to handle the case where POSIX ACL xattrs are treated differently by kernel during removexattr operation. ref: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/ceph/xattr.c#n21 Signed-off-by: Anoop C S <[email protected]>
1 parent adb1aee commit 655aedf

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/client/Client.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14069,7 +14069,6 @@ int Client::_removexattr(Inode *in, const char *name, const UserPerm& perms)
1406914069

1407014070
// same xattrs supported by kernel client
1407114071
if (strncmp(name, "user.", 5) &&
14072-
strncmp(name, "system.", 7) &&
1407314072
strncmp(name, "security.", 9) &&
1407414073
strncmp(name, "trusted.", 8) &&
1407514074
strncmp(name, "ceph.", 5))

0 commit comments

Comments
 (0)