Skip to content

Commit 66620cc

Browse files
committed
crimson/osd/pg: add PGLogEntryHandler::remove()
Fixes: https://tracker.ceph.com/issues/67564 Signed-off-by: Xuehan Xu <[email protected]>
1 parent 32c9183 commit 66620cc

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/crimson/osd/pg.cc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
#include "os/Transaction.h"
2828

2929
#include "crimson/common/exception.h"
30+
#include "crimson/common/log.h"
3031
#include "crimson/net/Connection.h"
3132
#include "crimson/net/Messenger.h"
3233
#include "crimson/os/cyanstore/cyan_store.h"
@@ -48,6 +49,8 @@ using std::set;
4849
using std::string;
4950
using std::vector;
5051

52+
SET_SUBSYS(osd);
53+
5154
namespace {
5255
seastar::logger& logger() {
5356
return crimson::get_logger(ceph_subsys_osd);
@@ -1787,4 +1790,10 @@ void PG::remove_maybe_snapmapped_object(
17871790
}
17881791
}
17891792
}
1793+
1794+
void PG::PGLogEntryHandler::remove(const hobject_t &soid) {
1795+
LOG_PREFIX(PG::PGLogEntryHandler::remove);
1796+
DEBUGDPP("remove {} on pglog rollback", *pg, soid);
1797+
pg->remove_maybe_snapmapped_object(*t, soid);
1798+
}
17901799
}

src/crimson/osd/pg.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ class PG : public boost::intrusive_ref_counter<
442442
PGLogEntryHandler(PG *pg, ceph::os::Transaction *t) : pg(pg), t(t) {}
443443

444444
// LogEntryHandler
445-
void remove(const hobject_t &soid) override {}
445+
void remove(const hobject_t &soid) override;
446446
void try_stash(const hobject_t &hoid, version_t v) override {
447447
// TODO
448448
}

0 commit comments

Comments
 (0)