libcephfs_proxy: fix userperm pointer decoding for older protocols

xhernandez · xhernandez · commit 674bd44001d6 · 2025-09-09T15:12:35.000+02:00
The random data used to decode pointers coming from the old protocol was taken from the client instead of using the global_random data, which is the correct one. Fixes: https://tracker.ceph.com/issues/72800 Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
diff --git a/src/libcephfs_proxy/libcephfsd.c b/src/libcephfs_proxy/libcephfsd.c
@@ -89,7 +89,7 @@ static int32_t validate_perms(proxy_client_t *client, embedded_perms_t *embed,
 
 	if ((client->neg.v1.enabled & PROXY_FEAT_EMBEDDED_PERMS) == 0) {
 		*embedded = false;
-		return ptr_check(&client->random, embed->ptr, (void **)pperms);
+		return ptr_check(&global_random, embed->ptr, (void **)pperms);
 	}
 
 	perms = ceph_userperm_new(embed->uid, embed->gid, count,

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ static int32_t validate_perms(proxy_client_t client, embedded_perms_t embed,`
`89`	`89`
`90`	`90`	`if ((client->neg.v1.enabled & PROXY_FEAT_EMBEDDED_PERMS) == 0) {`
`91`	`91`	`*embedded = false;`
`92`		`- return ptr_check(&client->random, embed->ptr, (void **)pperms);`
	`92`	`+ return ptr_check(&global_random, embed->ptr, (void **)pperms);`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`perms = ceph_userperm_new(embed->uid, embed->gid, count,`