messages: fix MOSDOpReplay decode of old version bad_replay_version

When decoding an old version of MOSDOpReplay or when the PGID64
feature is enabled, bad_replay_version is not being set, which
causes inconsistent output in ceph-dencoder.

To fix this, set bad_replay_version to the head reassert_version
value. This ensures that if the struct is later re-encoded, the
decode output will be consistent.

Fixes: https://tracker.ceph.com/issues/69814
Signed-off-by: Nitzan Mordechai <[email protected]>

Author: NitzanMordhai

src/messages/MOSDOpReply.h

@@ -271,6 +271,7 @@ class MOSDOpReply final : public Message {
       pgid = pg_t(head.layout.ol_pgid);
       result.set_wire_to_host((int32_t)head.result);
       flags = head.flags;
+      bad_replay_version = head.reassert_version;
       replay_version = head.reassert_version;
       user_version = replay_version.version;
       osdmap_epoch = head.osdmap_epoch;