Skip to content

Commit 705e60f

Browse files
committed
common: MemoryModel: do not store measurements
in the object itself Signed-off-by: Ronen Friedman <[email protected]>
1 parent bdc5782 commit 705e60f

File tree

2 files changed

+8
-25
lines changed

2 files changed

+8
-25
lines changed

src/common/MemoryModel.cc

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,3 @@ tl::expected<mem_snap_t, std::string> MemoryModel::full_sample()
143143
s.heap = static_cast<long>(get_mapped_heap().value_or(0));
144144
return s;
145145
}
146-
147-
void MemoryModel::sample(mem_snap_t *p)
148-
{
149-
auto s = full_sample();
150-
if (s) {
151-
last = *s;
152-
if (p)
153-
*p = last;
154-
}
155-
}

src/common/MemoryModel.h

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,18 @@
2626
class MemoryModel {
2727
public:
2828
struct mem_snap_t {
29-
long peak;
30-
long size;
31-
long hwm;
32-
long rss;
33-
long data;
34-
long lib;
35-
36-
long heap;
37-
38-
mem_snap_t() : peak(0), size(0), hwm(0), rss(0), data(0), lib(0),
39-
heap(0)
40-
{}
29+
long peak{0};
30+
long size{0};
31+
long hwm{0};
32+
long rss{0};
33+
long data{0};
34+
long lib{0};
35+
long heap{0};
4136

4237
long get_total() const { return size; }
4338
long get_rss() const { return rss; }
4439
long get_heap() const { return heap; }
45-
} last;
40+
};
4641

4742
private:
4843
static inline constexpr const char* proc_stat_fn = PROCPREFIX "/proc/self/status";
@@ -81,8 +76,6 @@ class MemoryModel {
8176
* size will be reported as 0).
8277
*/
8378
tl::expected<mem_snap_t, std::string> full_sample();
84-
85-
void sample(mem_snap_t *p = nullptr);
8679
};
8780

8881
#endif

0 commit comments

Comments
 (0)