Skip to content

Commit 7154411

Browse files
pybind/mgr: remove vestigial basepython directives
Remove what I think are vestigial configuration parameters setting `basepython` in tox.ini. These may have been useful during the change from python 2 to 3, but I don't see them serving any useful purpose at this current time. In fact they now interfere with the ability to globally override the basepython version of all testenv's at once. So let's just remove them. We can always add it back if we find an issue in the future (and document it!). Signed-off-by: John Mulligan <[email protected]>
1 parent 61eb46a commit 7154411

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/pybind/mgr/tox.ini

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,6 @@ commands =
146146
{posargs:{[testenv:fix]modules}}
147147

148148
[testenv:pylint]
149-
basepython = python3
150149
deps =
151150
pylint
152151
modules =
@@ -155,7 +154,6 @@ commands =
155154
pylint {[pylint]addopts} {posargs:{[testenv:pylint]modules}}
156155

157156
[testenv:flake8]
158-
basepython = python3
159157
deps =
160158
flake8
161159
allowlist_externals = bash
@@ -182,7 +180,6 @@ commands =
182180
bash -c 'test $(git ls-files cephadm | grep ".py$" | grep -v tests | xargs grep "docker.io" | wc -l) == 13'
183181

184182
[testenv:jinjalint]
185-
basepython = python3
186183
deps =
187184
jinjaninja
188185
commands =

0 commit comments

Comments
 (0)