crimson/osd: Verbose assert_all aborts

Signed-off-by: Matan Breizman <[email protected]>

Author: Matan-B

src/crimson/osd/osd_operations/client_request.cc

@@ -316,7 +316,7 @@ ClientRequest::recover_missing_snaps(
     }
     return seastar::now();
   }).handle_error_interruptible(
-    crimson::ct_error::assert_all("unexpected error")
+    crimson::ct_error::assert_all(fmt::format("{} {} error", *pg, FNAME).c_str())
   );
   co_await std::move(resolve_oids);
 

src/crimson/osd/osd_operations/internal_client_request.cc

@@ -86,7 +86,8 @@ InternalClientRequest::with_interruption()
   co_await pg->obc_loader.load_and_lock(
     obc_manager, pg->get_lock_type(op_info)
   ).handle_error_interruptible(
-    crimson::ct_error::assert_all("unexpected error")
+    crimson::ct_error::assert_all(
+      fmt::format("{} {} {} error when loading {}",*pg, FNAME, *this, get_target_oid()).c_str())
   );
 
   auto params = get_do_osd_ops_params();
@@ -96,12 +97,8 @@ InternalClientRequest::with_interruption()
   co_await pg->run_executer(
     ox, obc_manager.get_obc(), op_info, osd_ops
   ).handle_error_interruptible(
-    crimson::ct_error::all_same_way(
-      [this, FNAME](auto e) {
-	ERRORDPPI("{}: got unexpected error {}", *pg, *this, e);
-	ceph_assert(0 == "should not return an error");
-	return interruptor::now();
-      })
+    crimson::ct_error::assert_all(
+      fmt::format("{} {} {}: got unexpected error {}", *pg, FNAME, *this, get_target_oid()).c_str())
   );
 
   auto [submitted, completed] = co_await pg->submit_executer(

src/crimson/osd/osd_operations/snaptrim_event.cc

@@ -412,7 +412,8 @@ SnapTrimObjSubEvent::start()
     obc_manager, RWState::RWWRITE
   ).handle_error_interruptible(
     remove_or_update_iertr::pass_further{},
-    crimson::ct_error::assert_all{"unexpected error in SnapTrimObjSubEvent"}
+    crimson::ct_error::assert_all{fmt::format(
+      "{} error SnapTrimObjSubEvent::snap_trim_obj_subevent_ret_t with {}", *this, coid).c_str()}
   );
 
   logger().debug("{}: got obc={}", *this, obc_manager.get_obc()->get_oid());

src/crimson/osd/pg.cc

@@ -730,7 +730,8 @@ seastar::future<> PG::init(
         t.touch(coll_ref->get_cid(), pgid.make_snapmapper_oid());
       }
     },
-    ::crimson::ct_error::assert_all{"unexpected eio"}
+    ::crimson::ct_error::assert_all{fmt::format(
+      "{} {} unexpected eio", *this, __func__).c_str()}
   );
 }
 

src/crimson/osd/pg_backend.cc

@@ -1759,8 +1759,9 @@ PGBackend::tmapup_iertr::future<> PGBackend::tmapup(
       return seastar::make_ready_future<bufferlist>();
     }),
     PGBackend::write_iertr::pass_further{},
-    crimson::ct_error::assert_all{"read error in mutate_object_contents"}
-  ).si_then([this, &os, &osd_op, &txn,
+    crimson::ct_error::assert_all{fmt::format(
+      "read error in mutate_object_contents of {}", os.oi.soid).c_str()
+    }).si_then([this, &os, &osd_op, &txn,
 	     &delta_stats, &osd_op_params]
 	    (auto &&bl) mutable -> PGBackend::tmapup_iertr::future<> {
     auto result = crimson::common::do_tmap_up(

src/crimson/osd/recovery_backend.cc

@@ -246,7 +246,7 @@ RecoveryBackend::scan_for_backfill(
       crimson::ct_error::enoent::handle([](auto) {
 	return false;
       }),
-      crimson::ct_error::assert_all("unexpected error")
+      crimson::ct_error::assert_all(fmt::format("{} {} error when loading obc", pg, FNAME).c_str())
     );
     if (!found) {
       // if the object does not exist here, it must have been removed

src/crimson/osd/replicated_recovery_backend.cc

@@ -153,7 +153,8 @@ ReplicatedRecoveryBackend::maybe_pull_missing_obj(
       return recovery_waiter.wait_for_pull();
     });
   }).handle_error_interruptible(
-    crimson::ct_error::assert_all("unexpected error")
+    crimson::ct_error::assert_all(fmt::format(
+      "{} {} error with {} need {} ", pg, FNAME, soid, need).c_str())
   );
 }
 
@@ -746,7 +747,8 @@ ReplicatedRecoveryBackend::read_omap_for_push_op(
       return seastar::make_ready_future<seastar::stop_iteration>(
         stop ? seastar::stop_iteration::yes : seastar::stop_iteration::no
       );
-    }, crimson::os::FuturizedStore::Shard::read_errorator::assert_all{});
+    }, crimson::os::FuturizedStore::Shard::read_errorator::assert_all(fmt::format(
+         "{} ReplicatedRecoveryBackend::read_omap_for_push_op error with {}", pg, oid).c_str()));
   });
 }