mgr/smb: Add new configs to share definition

Inorder to support Microsoft Management Console (MMC) plugin feature,
ceph manager must handle all fields supported by `add share command`
and related smb.conf options.

Added "comment" and "max connections" entries to the Samba
configuration generated by the Ceph Manager module. These fields
are required for MMC integration and will be made configurable in a
future update.

Signed-off-by: Shwetha K Acharya <[email protected]>

Author: Shwetha-Acharya

qa/suites/orch/cephadm/smb/tasks/deploy_smb_basic.yaml

@@ -51,6 +51,8 @@ tasks:
             "kernel share modes" = "no"
             "read only" = "no"
             "browseable" = "yes"
+            "comment" = ""
+            "max connections" = "0"
             [globals.default.options]
             "load printers" = "no"
             "printing" = "bsd"

qa/suites/orch/cephadm/smb/tasks/deploy_smb_domain.yaml

@@ -50,6 +50,8 @@ tasks:
           "kernel share modes" = "no"
           "read only" = "no"
           "browseable" = "yes"
+          "comment" = ""
+          "max connections" = "0"
           [globals.default.options]
           "load printers" = "no"
           "printing" = "bsd"

src/pybind/mgr/smb/handler.py

@@ -1196,6 +1196,8 @@ def _generate_share(
             'browseable': ynbool(share.browseable),
             'kernel share modes': 'no',
             'x:ceph:id': f'{share.cluster_id}.{share.share_id}',
+            'comment': '',
+            'max connections': '0',
         }
     }
     if proxy_val: