Skip to content

Commit 75bd7e3

Browse files
authored
Merge pull request ceph#54025 from yuvalif/wip-yuval-fix-63205
rgw/notifications/test: fix rabbitmq and kafka issues in centos9 reviewed-by: cbodley
2 parents 10d3caa + 2ab7c16 commit 75bd7e3

File tree

4 files changed

+21
-20
lines changed

4 files changed

+21
-20
lines changed

qa/suites/rgw/notifications/tasks/0-install.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ tasks:
66
client.0:
77

88
overrides:
9+
install:
10+
ceph:
11+
extra_system_packages:
12+
rpm:
13+
- java
14+
deb:
15+
- default-jre
916
ceph:
1017
conf:
1118
global:

qa/tasks/kafka.py

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ def get_kafka_version(config):
1717
kafka_version = client_config.get('kafka_version')
1818
return kafka_version
1919

20+
kafka_prefix = 'kafka_2.13-'
21+
2022
def get_kafka_dir(ctx, config):
2123
kafka_version = get_kafka_version(config)
22-
current_version = 'kafka-' + kafka_version + '-src'
24+
current_version = kafka_prefix + kafka_version
2325
return '{tdir}/{ver}'.format(tdir=teuthology.get_testdir(ctx),ver=current_version)
2426

2527

@@ -36,14 +38,15 @@ def install_kafka(ctx, config):
3638
test_dir=teuthology.get_testdir(ctx)
3739
current_version = get_kafka_version(config)
3840

39-
link1 = 'https://archive.apache.org/dist/kafka/' + current_version + '/kafka-' + current_version + '-src.tgz'
41+
kafka_file = kafka_prefix + current_version + '.tgz'
42+
43+
link1 = 'https://archive.apache.org/dist/kafka/' + current_version + '/' + kafka_file
4044
ctx.cluster.only(client).run(
4145
args=['cd', '{tdir}'.format(tdir=test_dir), run.Raw('&&'), 'wget', link1],
4246
)
4347

44-
file1 = 'kafka-' + current_version + '-src.tgz'
4548
ctx.cluster.only(client).run(
46-
args=['cd', '{tdir}'.format(tdir=test_dir), run.Raw('&&'), 'tar', '-xvzf', file1],
49+
args=['cd', '{tdir}'.format(tdir=test_dir), run.Raw('&&'), 'tar', '-xvzf', kafka_file],
4750
)
4851

4952
try:
@@ -61,9 +64,8 @@ def install_kafka(ctx, config):
6164
args=['rm', '-rf', test_dir],
6265
)
6366

64-
rmfile1 = 'kafka-' + current_version + '-src.tgz'
6567
ctx.cluster.only(client).run(
66-
args=['rm', '-rf', '{tdir}/{doc}'.format(tdir=teuthology.get_testdir(ctx),doc=rmfile1)],
68+
args=['rm', '-rf', '{tdir}/{doc}'.format(tdir=teuthology.get_testdir(ctx),doc=kafka_file)],
6769
)
6870

6971

@@ -79,13 +81,6 @@ def run_kafka(ctx,config):
7981
for (client,_) in config.items():
8082
(remote,) = ctx.cluster.only(client).remotes.keys()
8183

82-
ctx.cluster.only(client).run(
83-
args=['cd', '{tdir}'.format(tdir=get_kafka_dir(ctx, config)), run.Raw('&&'),
84-
'./gradlew', 'jar',
85-
'-PscalaVersion=2.13.2'
86-
],
87-
)
88-
8984
ctx.cluster.only(client).run(
9085
args=['cd', '{tdir}/bin'.format(tdir=get_kafka_dir(ctx, config)), run.Raw('&&'),
9186
'./zookeeper-server-start.sh',

qa/tasks/rabbitmq.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def install_rabbitmq(ctx, config):
2323
(remote,) = ctx.cluster.only(client).remotes.keys()
2424

2525
ctx.cluster.only(client).run(args=[
26-
'sudo', 'yum', '-y', 'install', 'epel-release'
26+
'sudo', 'dnf', '-y', 'install', 'epel-release'
2727
])
2828

2929
link1 = 'https://packagecloud.io/install/repositories/rabbitmq/erlang/script.rpm.sh'
@@ -33,7 +33,7 @@ def install_rabbitmq(ctx, config):
3333
])
3434

3535
ctx.cluster.only(client).run(args=[
36-
'sudo', 'yum', '-y', 'install', 'erlang'
36+
'sudo', 'dnf', '-y', 'install', 'erlang'
3737
])
3838

3939
link2 = 'https://packagecloud.io/install/repositories/rabbitmq/rabbitmq-server/script.rpm.sh'
@@ -43,7 +43,7 @@ def install_rabbitmq(ctx, config):
4343
])
4444

4545
ctx.cluster.only(client).run(args=[
46-
'sudo', 'yum', '-y', 'install', 'rabbitmq-server'
46+
'sudo', 'dnf', '-y', 'install', 'rabbitmq-server'
4747
])
4848

4949
try:
@@ -53,7 +53,7 @@ def install_rabbitmq(ctx, config):
5353

5454
for (client, _) in config.items():
5555
ctx.cluster.only(client).run(args=[
56-
'sudo', 'yum', '-y', 'remove', 'rabbitmq-server.noarch'
56+
'sudo', 'dnf', '-y', 'remove', 'rabbitmq-server.noarch'
5757
])
5858

5959

@@ -70,7 +70,7 @@ def run_rabbitmq(ctx, config):
7070
(remote,) = ctx.cluster.only(client).remotes.keys()
7171

7272
ctx.cluster.only(client).run(args=[
73-
'sudo', 'chkconfig', 'rabbitmq-server', 'on'
73+
'sudo', 'systemctl', 'enable', 'rabbitmq-server.service'
7474
],
7575
)
7676

src/test/rgw/bucket_notification/test_bn.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1615,8 +1615,7 @@ def test_ps_s3_notification_push_kafka_on_master():
16151615
time.sleep(5)
16161616
receiver.verify_s3_events(keys, exact_match=True, deletions=True, etags=etags)
16171617
except Exception as e:
1618-
print(e)
1619-
assert False
1618+
assert False, str(e)
16201619
finally:
16211620
# cleanup
16221621
if s3_notification_conf is not None:

0 commit comments

Comments
 (0)