Skip to content

Commit 79729c4

Browse files
committed
mgr/dashboard: close token status subscription properly
Since its not returning any subscription back to the `this.subs` property, those subscriptions are not properly closed in the workbench-layout when its destroyed. So ensuring proper return Fixes: https://tracker.ceph.com/issues/72530 Signed-off-by: Nizamudeen A <[email protected]>
1 parent bfab9f7 commit 79729c4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/pybind/mgr/dashboard/frontend/src/app/shared/api/multi-cluster.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ export class MultiClusterService {
3333
}
3434

3535
startClusterTokenStatusPolling() {
36-
this.checkAndStartTimer();
36+
return this.checkAndStartTimer();
3737
}
3838

3939
private checkAndStartTimer() {
4040
this.checkTokenStatus().subscribe(this.getClusterTokenStatusObserver());
41-
this.timerService
41+
return this.timerService
4242
.get(() => this.checkTokenStatus(), this.TOKEN_CHECK_INTERVAL)
4343
.subscribe(this.getClusterTokenStatusObserver());
4444
}

0 commit comments

Comments
 (0)