crimson/osd/pg: remove slightly confusing assert from PG::submit_transaction

athanatos · athanatos · commit 7a04f6230d93 · 2024-05-08T19:38:40.000-07:00
This assert should always hold, so it's not wrong.  However,
osd_op_p.at_version is chosen during transaction construction time
using the current epoch via PG::get_next_version.  Asserting it here
is more confusing than helpful.

Signed-off-by: Samuel Just &lt;sjust@redhat.com&gt;
diff --git a/src/crimson/osd/pg.cc b/src/crimson/osd/pg.cc
@@ -811,7 +811,6 @@ PG::submit_transaction(
   }
 
   epoch_t map_epoch = get_osdmap_epoch();
-  ceph_assert(!has_reset_since(osd_op_p.at_version.epoch));
 
   peering_state.pre_submit_op(obc->obs.oi.soid, log_entries, osd_op_p.at_version);
   peering_state.update_trim_to();

Original file line number	Diff line number	Diff line change
`@@ -811,7 +811,6 @@ PG::submit_transaction(`
`811`	`811`	`}`
`812`	`812`
`813`	`813`	`epoch_t map_epoch = get_osdmap_epoch();`
`814`		`- ceph_assert(!has_reset_since(osd_op_p.at_version.epoch));`
`815`	`814`
`816`	`815`	`peering_state.pre_submit_op(obc->obs.oi.soid, log_entries, osd_op_p.at_version);`
`817`	`816`	`peering_state.update_trim_to();`