RGW: Rename rgw::sal::Object::get_obj_size() to get_size()

dang · dang · commit 7d4c8781e548 · 2024-05-28T12:22:03.000-04:00
Signed-off-by: Daniel Gryniewicz &lt;dang@redhat.com&gt;
diff --git a/src/rgw/driver/d4n/rgw_sal_d4n.cc b/src/rgw/driver/d4n/rgw_sal_d4n.cc
@@ -944,7 +944,7 @@ int D4NFilterWriter::complete(size_t accounted_size, const std::string& etag,
   baseAttrs.insert({"mtime", bl});
   bl.clear();
 
-  bl.append(std::to_string(obj->get_obj_size()));
+  bl.append(std::to_string(obj->get_size()));
   baseAttrs.insert({"object_size", bl});
   bl.clear();
 
diff --git a/src/rgw/driver/motr/rgw_sal_motr.cc b/src/rgw/driver/motr/rgw_sal_motr.cc
@@ -1393,7 +1393,7 @@ int MotrObject::MotrReadOp::prepare(optional_yield y, const DoutPrefixProvider*
   }
 
   // Skip opening an empty object.
-  if(source->get_obj_size() == 0)
+  if(source->get_size() == 0)
     return 0;
 
   // Open the object here.
diff --git a/src/rgw/driver/posix/rgw_sal_posix.cc b/src/rgw/driver/posix/rgw_sal_posix.cc
@@ -597,7 +597,7 @@ int POSIXObject::fill_bde(const DoutPrefixProvider *dpp, optional_yield y, rgw_b
     bde.ver.epoch = 1;
     bde.exists = true;
     bde.meta.category = RGWObjCategory::Main;
-    bde.meta.size = get_obj_size();
+    bde.meta.size = get_size();
     bde.meta.mtime = get_mtime();
     if (owner) {
       bde.meta.owner = owner->get_id().to_str();
@@ -606,7 +606,7 @@ int POSIXObject::fill_bde(const DoutPrefixProvider *dpp, optional_yield y, rgw_b
       bde.meta.owner = "unknown";
       bde.meta.owner_display_name = "unknown";
     }
-    bde.meta.accounted_size = get_obj_size();
+    bde.meta.accounted_size = get_size();
     bde.meta.storage_class = RGW_STORAGE_CLASS_STANDARD;
     bde.meta.appendable = true;
     bufferlist etag_bl;
@@ -2244,7 +2244,7 @@ int POSIXObject::generate_mp_etag(const DoutPrefixProvider* dpp, optional_yield
 
 int POSIXObject::generate_etag(const DoutPrefixProvider* dpp, optional_yield y)
 {
-  int64_t left = get_obj_size();
+  int64_t left = get_size();
   int64_t cur_ofs = 0;
   MD5 hash;
   // Allow use of MD5 digest in FIPS mode for non-cryptographic purposes
diff --git a/src/rgw/driver/posix/rgw_sal_posix.h b/src/rgw/driver/posix/rgw_sal_posix.h
@@ -511,7 +511,7 @@ class POSIXMultipartPart : public StoreMultipartPart {
   virtual ~POSIXMultipartPart() = default;
 
   virtual uint32_t get_num() { return info.num; }
-  virtual uint64_t get_size() { return shadow->get_obj_size(); }
+  virtual uint64_t get_size() { return shadow->get_size(); }
   virtual const std::string& get_etag() { return info.etag; }
   virtual ceph::real_time& get_mtime() { return info.mtime; }
 
diff --git a/src/rgw/driver/rados/rgw_cr_rados.cc b/src/rgw/driver/rados/rgw_cr_rados.cc
@@ -952,7 +952,7 @@ int RGWAsyncRemoveObj::_send_request(const DoutPrefixProvider *dpp)
   } else {
     send_sync_notification(
         dpp, store, bucket.get(), obj.get(), obj->get_attrs(),
-        obj->get_obj_size(),
+        obj->get_size(),
         {rgw::notify::ObjectSyncedDelete, rgw::notify::ReplicationDelete});
   }
   return ret;
diff --git a/src/rgw/driver/rados/rgw_lc_tier.cc b/src/rgw/driver/rados/rgw_lc_tier.cc
@@ -426,7 +426,7 @@ int RGWLCStreamRead::init() {
   }
 
   attrs = obj->get_attrs();
-  obj_size = obj->get_obj_size();
+  obj_size = obj->get_size();
 
   ret = init_rest_obj();
   if (ret < 0) {
diff --git a/src/rgw/rgw_admin.cc b/src/rgw/rgw_admin.cc
@@ -1643,7 +1643,7 @@ int check_min_obj_stripe_size(rgw::sal::Driver* driver, rgw::sal::Object* obj, u
   map<string, bufferlist>::iterator iter;
   iter = obj->get_attrs().find(RGW_ATTR_MANIFEST);
   if (iter == obj->get_attrs().end()) {
-    *need_rewrite = (obj->get_obj_size() >= min_stripe_size);
+    *need_rewrite = (obj->get_size() >= min_stripe_size);
     return 0;
   }
 
@@ -8562,7 +8562,7 @@ int main(int argc, const char **argv)
     }
     formatter->open_object_section("object_metadata");
     formatter->dump_string("name", object);
-    formatter->dump_unsigned("size", obj->get_obj_size());
+    formatter->dump_unsigned("size", obj->get_size());
 
     map<string, bufferlist>::iterator iter;
     map<string, bufferlist> other_attrs;
@@ -8633,7 +8633,7 @@ int main(int argc, const char **argv)
     }
 
     formatter->open_object_section("outer");  // name not displayed since top level
-    formatter->dump_unsigned("size", obj->get_obj_size());
+    formatter->dump_unsigned("size", obj->get_size());
 
     auto attr_iter = obj->get_attrs().find(RGW_ATTR_MANIFEST);
     if (attr_iter == obj->get_attrs().end()) {
diff --git a/src/rgw/rgw_lc.cc b/src/rgw/rgw_lc.cc
@@ -523,10 +523,10 @@ static bool pass_size_limit_checks(const DoutPrefixProvider *dpp, lc_op_ctx& oc)
     bool lt_p{true};
 
     if (op.size_gt) {
-      gt_p = (obj->get_obj_size() > op.size_gt.get());
+      gt_p = (obj->get_size() > op.size_gt.get());
     }
     if (op.size_lt) {
-      lt_p = (obj->get_obj_size() < op.size_lt.get());
+      lt_p = (obj->get_size() < op.size_lt.get());
     }
 
     return gt_p && lt_p;
@@ -625,7 +625,7 @@ static int remove_expired_obj(const DoutPrefixProvider* dpp,
       fmt::format("ERROR: {} failed, with error: {}", __func__, ret) << dendl;
   } else {
     // send request to notification manager
-    int publish_ret = notify->publish_commit(dpp, obj->get_obj_size(),
+    int publish_ret = notify->publish_commit(dpp, obj->get_size(),
 				 ceph::real_clock::now(),
 				 etag,
 				 version_id);
@@ -922,7 +922,7 @@ int RGWLC::handle_multipart_expiration(rgw::sal::Bucket* target,
       ret = mpu->abort(this, cct, null_yield);
       if (ret == 0) {
         int publish_ret = notify->publish_commit(
-            this, sal_obj->get_obj_size(),
+            this, sal_obj->get_size(),
 	    ceph::real_clock::now(),
             etag,
 	    version_id);
@@ -1454,7 +1454,7 @@ class LCOpAction_Transition : public LCOpAction {
       return ret;
     } else {
       // send request to notification manager
-      int publish_ret =  notify->publish_commit(oc.dpp, obj->get_obj_size(),
+      int publish_ret =  notify->publish_commit(oc.dpp, obj->get_size(),
 				    ceph::real_clock::now(),
 				    etag,
 				    version_id);
diff --git a/src/rgw/rgw_lua_request.cc b/src/rgw/rgw_lua_request.cc
@@ -355,7 +355,7 @@ struct ObjectMetaTable : public EmptyMetaTable {
     } else if (strcasecmp(index, "Id") == 0) {
       pushstring(L, obj->get_oid());
     } else if (strcasecmp(index, "Size") == 0) {
-      lua_pushinteger(L, obj->get_obj_size());
+      lua_pushinteger(L, obj->get_size());
     } else if (strcasecmp(index, "MTime") == 0) {
       pushtime(L, obj->get_mtime());
     } else {
diff --git a/src/rgw/rgw_op.cc b/src/rgw/rgw_op.cc
@@ -1658,9 +1658,9 @@ int RGWGetObj::read_user_manifest_part(rgw::sal::Bucket* bucket,
   }
   else
   {
-    if (part->get_obj_size() != ent.meta.size) {
+    if (part->get_size() != ent.meta.size) {
       // hmm.. something wrong, object not as expected, abort!
-      ldpp_dout(this, 0) << "ERROR: expected obj_size=" << part->get_obj_size()
+      ldpp_dout(this, 0) << "ERROR: expected obj_size=" << part->get_size()
           << ", actual read size=" << ent.meta.size << dendl;
       return -EIO;
 	  }
@@ -2235,7 +2235,7 @@ void RGWGetObj::execute(optional_yield y)
 
   op_ret = read_op->prepare(s->yield, this);
   version_id = s->object->get_instance();
-  s->obj_size = s->object->get_obj_size();
+  s->obj_size = s->object->get_size();
   attrs = s->object->get_attrs();
   multipart_parts_count = read_op->params.parts_count;
   if (op_ret < 0)
@@ -3995,7 +3995,7 @@ int RGWPutObj::get_data(const off_t fst, const off_t lst, bufferlist& bl)
   if (ret < 0)
     return ret;
 
-  obj_size = obj->get_obj_size();
+  obj_size = obj->get_size();
 
   bool need_decompress;
   op_ret = rgw_compression_info_from_attrset(obj->get_attrs(), need_decompress, cs_info);
@@ -5136,7 +5136,7 @@ void RGWDeleteObj::execute(optional_yield y)
           }
         }
       } else {
-        obj_size = s->object->get_obj_size();
+        obj_size = s->object->get_size();
         etag = s->object->get_attrs()[RGW_ATTR_ETAG].to_str();
       }
 
@@ -5550,7 +5550,7 @@ void RGWCopyObj::execute(optional_yield y)
       }
     }
 
-    obj_size = s->src_object->get_obj_size();
+    obj_size = s->src_object->get_size();
   
     if (!s->system_request) { // no quota enforcement for system requests
       if (s->src_object->get_accounted_size() > static_cast<size_t>(s->cct->_conf->rgw_max_put_size)) {
@@ -6724,7 +6724,7 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key& o, optional_
         return;
       }
     } else {
-      obj_size = obj->get_obj_size();
+      obj_size = obj->get_size();
       etag = obj->get_attrs()[RGW_ATTR_ETAG].to_str();
     }
 
diff --git a/src/rgw/rgw_rest_swift.cc b/src/rgw/rgw_rest_swift.cc
@@ -988,7 +988,7 @@ int RGWPutObj_ObjStore_SWIFT::update_slo_segment_size(rgw_slo_entry& entry) {
     return r;
   }
 
-  size_bytes = slo_seg->get_obj_size();
+  size_bytes = slo_seg->get_size();
 
   r = rgw_compression_info_from_attrset(slo_seg->get_attrs(), compressed, cs_info);
   if (r < 0) {
@@ -2729,7 +2729,7 @@ bool RGWSwiftWebsiteHandler::is_web_dir() const
   const std::string subdir_marker = ws_conf.subdir_marker.empty()
                                       ? "application/directory"
                                       : ws_conf.subdir_marker;
-  return subdir_marker == content_type && obj->get_obj_size() <= 1;
+  return subdir_marker == content_type && obj->get_size() <= 1;
 }
 
 bool RGWSwiftWebsiteHandler::is_index_present(const std::string& index) const
diff --git a/src/rgw/rgw_sal.h b/src/rgw/rgw_sal.h
@@ -1208,7 +1208,7 @@ class Object {
     /** Set the cached modification time for this object */
     virtual void set_mtime(ceph::real_time&) = 0;
     /** Get the cached size for this object */
-    virtual uint64_t get_obj_size(void) const = 0;
+    virtual uint64_t get_size(void) const = 0;
     /** Get the cached accounted size for this object */
     virtual uint64_t get_accounted_size(void) const = 0;
     /** Set the cached accounted size for this object */
diff --git a/src/rgw/rgw_sal_filter.h b/src/rgw/rgw_sal_filter.h
@@ -796,7 +796,7 @@ class FilterObject : public Object {
   virtual bool get_attr(const std::string& name, bufferlist &dest) override { return next->get_attr(name, dest); }
   virtual ceph::real_time get_mtime(void) const override { return next->get_mtime(); };
   virtual void set_mtime(ceph::real_time& mtime) override { return next->set_mtime(mtime); }
-  virtual uint64_t get_obj_size(void) const override { return next->get_obj_size(); };
+  virtual uint64_t get_size(void) const override { return next->get_size(); };
   virtual uint64_t get_accounted_size(void) const override { return next->get_accounted_size(); };
   virtual void set_accounted_size(uint64_t size) override { return next->set_accounted_size(size); }
   virtual uint64_t get_epoch(void) const override { return next->get_epoch(); }
diff --git a/src/rgw/rgw_sal_store.h b/src/rgw/rgw_sal_store.h
@@ -312,7 +312,7 @@ class StoreObject : public Object {
     }
     virtual ceph::real_time get_mtime(void) const override { return state.mtime; }
     virtual void set_mtime(ceph::real_time& mtime) override { state.mtime = mtime; }
-    virtual uint64_t get_obj_size(void) const override { return state.size; }
+    virtual uint64_t get_size(void) const override { return state.size; }
     virtual uint64_t get_accounted_size(void) const override { return state.accounted_size; }
     virtual void set_accounted_size(uint64_t size) override { state.accounted_size = size; }
     virtual uint64_t get_epoch(void) const override { return state.epoch; }

Original file line number	Diff line number	Diff line change
`@@ -1393,7 +1393,7 @@ int MotrObject::MotrReadOp::prepare(optional_yield y, const DoutPrefixProvider*`
`1393`	`1393`	`}`
`1394`	`1394`
`1395`	`1395`	`// Skip opening an empty object.`
`1396`		`- if(source->get_obj_size() == 0)`
	`1396`	`+ if(source->get_size() == 0)`
`1397`	`1397`	`return 0;`
`1398`	`1398`
`1399`	`1399`	`// Open the object here.`
Original file line number	Diff line number	Diff line change
`@@ -952,7 +952,7 @@ int RGWAsyncRemoveObj::_send_request(const DoutPrefixProvider *dpp)`
`952`	`952`	`} else {`
`953`	`953`	`send_sync_notification(`
`954`	`954`	`dpp, store, bucket.get(), obj.get(), obj->get_attrs(),`
`955`		`- obj->get_obj_size(),`
	`955`	`+ obj->get_size(),`
`956`	`956`	`{rgw::notify::ObjectSyncedDelete, rgw::notify::ReplicationDelete});`
`957`	`957`	`}`
`958`	`958`	`return ret;`
Original file line number	Diff line number	Diff line change
`@@ -426,7 +426,7 @@ int RGWLCStreamRead::init() {`
`426`	`426`	`}`
`427`	`427`
`428`	`428`	`attrs = obj->get_attrs();`
`429`		`- obj_size = obj->get_obj_size();`
	`429`	`+ obj_size = obj->get_size();`
`430`	`430`
`431`	`431`	`ret = init_rest_obj();`
`432`	`432`	`if (ret < 0) {`
Original file line number	Diff line number	Diff line change
`@@ -1658,9 +1658,9 @@ int RGWGetObj::read_user_manifest_part(rgw::sal::Bucket* bucket,`
`1658`	`1658`	`}`
`1659`	`1659`	`else`
`1660`	`1660`	`{`
`1661`		`- if (part->get_obj_size() != ent.meta.size) {`
	`1661`	`+ if (part->get_size() != ent.meta.size) {`
`1662`	`1662`	`// hmm.. something wrong, object not as expected, abort!`
`1663`		`- ldpp_dout(this, 0) << "ERROR: expected obj_size=" << part->get_obj_size()`
	`1663`	`+ ldpp_dout(this, 0) << "ERROR: expected obj_size=" << part->get_size()`
`1664`	`1664`	`<< ", actual read size=" << ent.meta.size << dendl;`
`1665`	`1665`	`return -EIO;`
`1666`	`1666`	`}`
`@@ -2235,7 +2235,7 @@ void RGWGetObj::execute(optional_yield y)`
`2235`	`2235`
`2236`	`2236`	`op_ret = read_op->prepare(s->yield, this);`
`2237`	`2237`	`version_id = s->object->get_instance();`
`2238`		`- s->obj_size = s->object->get_obj_size();`
	`2238`	`+ s->obj_size = s->object->get_size();`
`2239`	`2239`	`attrs = s->object->get_attrs();`
`2240`	`2240`	`multipart_parts_count = read_op->params.parts_count;`
`2241`	`2241`	`if (op_ret < 0)`
`@@ -3995,7 +3995,7 @@ int RGWPutObj::get_data(const off_t fst, const off_t lst, bufferlist& bl)`
`3995`	`3995`	`if (ret < 0)`
`3996`	`3996`	`return ret;`
`3997`	`3997`
`3998`		`- obj_size = obj->get_obj_size();`
	`3998`	`+ obj_size = obj->get_size();`
`3999`	`3999`
`4000`	`4000`	`bool need_decompress;`
`4001`	`4001`	`op_ret = rgw_compression_info_from_attrset(obj->get_attrs(), need_decompress, cs_info);`
`@@ -5136,7 +5136,7 @@ void RGWDeleteObj::execute(optional_yield y)`
`5136`	`5136`	`}`
`5137`	`5137`	`}`
`5138`	`5138`	`} else {`
`5139`		`- obj_size = s->object->get_obj_size();`
	`5139`	`+ obj_size = s->object->get_size();`
`5140`	`5140`	`etag = s->object->get_attrs()[RGW_ATTR_ETAG].to_str();`
`5141`	`5141`	`}`
`5142`	`5142`
`@@ -5550,7 +5550,7 @@ void RGWCopyObj::execute(optional_yield y)`
`5550`	`5550`	`}`
`5551`	`5551`	`}`
`5552`	`5552`
`5553`		`- obj_size = s->src_object->get_obj_size();`
	`5553`	`+ obj_size = s->src_object->get_size();`
`5554`	`5554`
`5555`	`5555`	`if (!s->system_request) { // no quota enforcement for system requests`
`5556`	`5556`	`if (s->src_object->get_accounted_size() > static_cast<size_t>(s->cct->_conf->rgw_max_put_size)) {`
`@@ -6724,7 +6724,7 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key& o, optional_`
`6724`	`6724`	`return;`
`6725`	`6725`	`}`
`6726`	`6726`	`} else {`
`6727`		`- obj_size = obj->get_obj_size();`
	`6727`	`+ obj_size = obj->get_size();`
`6728`	`6728`	`etag = obj->get_attrs()[RGW_ATTR_ETAG].to_str();`
`6729`	`6729`	`}`
`6730`	`6730`