Skip to content

Commit 7d9fe0a

Browse files
mgr/smb: use is comparisions for enum values
Use `is` based comparisions for two enum related functions as mypy likes this better. Signed-off-by: John Mulligan <[email protected]>
1 parent cbbddfd commit 7d9fe0a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/pybind/mgr/smb/enums.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class CephFSStorageProvider(_StrEnum):
2121

2222
def expand(self) -> 'CephFSStorageProvider':
2323
"""Expand abbreviated/default values into the full/expanded form."""
24-
if self == self.SAMBA_VFS:
24+
if self is self.SAMBA_VFS:
2525
# mypy gets confused by enums
2626
return self.__class__(self.SAMBA_VFS_NEW)
2727
return self
@@ -89,9 +89,9 @@ class LoginAccess(_StrEnum):
8989
def expand(self) -> 'LoginAccess':
9090
"""Exapend abbreviated enum values into their full forms."""
9191
# the extra LoginAccess(...) calls are to appease mypy
92-
if self == self.READ_ONLY_SHORT:
92+
if self is self.READ_ONLY_SHORT:
9393
return LoginAccess(self.READ_ONLY)
94-
if self == self.READ_WRITE_SHORT:
94+
if self is self.READ_WRITE_SHORT:
9595
return LoginAccess(self.READ_WRITE)
9696
return self
9797

0 commit comments

Comments
 (0)