Merge pull request ceph#66377 from baum/rbd_aio_write_with_crc32c_initial_fix

librbd: rbd_aio_write_with_crc32c store CRC32C with initial value -1 to match msgr2 validation

Reviewed-by: Ilya Dryomov <[email protected]>

Author: idryomov

src/include/rbd/librbd.h

@@ -1280,9 +1280,11 @@ CEPH_RBD_API int rbd_aio_write(rbd_image_t image, uint64_t off, size_t len,
 CEPH_RBD_API int rbd_aio_write2(rbd_image_t image, uint64_t off, size_t len,
                                 const char *buf, rbd_completion_t c,
                                 int op_flags);
-
 /*
- * @param precomputed_crc32c: CRC32C checksum that was precomputed (e.g., by SPDK NVMf)
+ * @param precomputed_crc32c: CRC32C checksum that was precomputed with -1
+ *        as the initial value (i.e. with the CRC "register" initialized to
+ *        0xFFFFFFFF)
+ * @param op_flags: see librados.h constants beginning with LIBRADOS_OP_FLAG
  */
 CEPH_RBD_API int rbd_aio_write_with_crc32c(rbd_image_t image, uint64_t off,
                                            size_t len, const char *buf,

src/librbd/librbd.cc

@@ -6418,8 +6418,9 @@ extern "C" int rbd_aio_write_with_crc32c(rbd_image_t image, uint64_t off,
 
   auto aio_completion = get_aio_completion(comp);
   auto raw = create_write_raw(ictx, buf, len, aio_completion);
+  // store with initial value -1
   raw->set_crc(std::make_pair(0, len),
-               std::make_pair(0, precomputed_crc32c));
+               std::make_pair(-1, precomputed_crc32c));
   bufferlist bl;
   bl.push_back(std::move(raw));
   librbd::api::Io<>::aio_write(