Skip to content

Commit 7ef164e

Browse files
Matan-Bzhscn
authored andcommitted
crimson: fix -Wmissing-template-arg-list-after-template-kw
See: llvm/llvm-project@f46d146 ``` common/interruptible_future.h:1182:16: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw] 1182 | ).template handle_interruption(std::move(efunc)); | ^ 1 error generated. ``` Signed-off-by: Matan Breizman <[email protected]>
1 parent 05ea552 commit 7ef164e

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/crimson/common/interruptible_future.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1179,7 +1179,7 @@ struct interruptor
11791179
std::move(ic),
11801180
std::forward<OpFunc>(opfunc),
11811181
std::forward<Params>(params)...
1182-
).template handle_interruption(std::move(efunc));
1182+
).handle_interruption(std::move(efunc));
11831183
}
11841184

11851185
template <typename OpFunc, typename OnInterrupt,

src/crimson/os/seastore/onode_manager/staged-fltree/stages/stage.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,7 +1153,7 @@ struct staged {
11531153
return insert_size(key, value);
11541154
} else {
11551155
assert(stage < STAGE);
1156-
return NXT_STAGE_T::template insert_size_at(stage, key, value);
1156+
return NXT_STAGE_T::insert_size_at(stage, key, value);
11571157
}
11581158
}
11591159

@@ -1406,7 +1406,7 @@ struct staged {
14061406
return container_t::insert_at(
14071407
mut, container, key, value, 0, _insert_size, p_left_bound);
14081408
} else {
1409-
auto range = container_t::template insert_prefix_at(
1409+
auto range = container_t::insert_prefix_at(
14101410
mut, container, key, 0, _insert_size, p_left_bound);
14111411
return NXT_STAGE_T::template insert_new<KT>(mut, range, key, value);
14121412
}

src/crimson/osd/osd_operations/replicated_request.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ RepRequest::interruptible_future<> RepRequest::with_pg_interruptible(
9393
auto [commit_fut, reply] = co_await pg->handle_rep_op(req);
9494

9595
// Transitions from OrderedExclusive->OrderedConcurrent cannot block
96-
this->template enter_stage_sync(repop_pipeline(*pg).wait_commit);
96+
this->enter_stage_sync(repop_pipeline(*pg).wait_commit);
9797

9898
co_await std::move(commit_fut);
9999

src/crimson/osd/pg_shard_manager.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ seastar::future<> PGShardManager::load_pgs(crimson::os::FuturizedStore& store)
2626
return get_pg_to_shard_mapping().get_or_create_pg_mapping(
2727
pgid, shard_core
2828
).then([this, pgid] (auto core) {
29-
return this->template with_remote_shard_state(
29+
return this->with_remote_shard_state(
3030
core,
3131
[pgid](
3232
PerShardState &per_shard_state,

0 commit comments

Comments
 (0)