Skip to content

Commit 800b352

Browse files
committed
crimson/os/seastore/cache/lru: renames
Signed-off-by: Yingxin Cheng <[email protected]>
1 parent 2dddd07 commit 800b352

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/crimson/os/seastore/cache.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Cache::Cache(
4444
"seastore_cache_lru_size"))
4545
{
4646
LOG_PREFIX(Cache::Cache);
47-
INFO("created, lru_size={}", lru.get_capacity());
47+
INFO("created, lru_capacity={}B", lru.get_capacity_bytes());
4848
register_metrics();
4949
segment_providers_by_device_id.resize(DEVICE_ID_MAX, nullptr);
5050
}
@@ -509,14 +509,14 @@ void Cache::register_metrics()
509509
sm::make_counter(
510510
"cache_lru_size_bytes",
511511
[this] {
512-
return lru.get_current_contents_bytes();
512+
return lru.get_current_size_bytes();
513513
},
514514
sm::description("total bytes pinned by the lru")
515515
),
516516
sm::make_counter(
517-
"cache_lru_size_extents",
517+
"cache_lru_num_extents",
518518
[this] {
519-
return lru.get_current_contents_extents();
519+
return lru.get_current_num_extents();
520520
},
521521
sm::description("total extents pinned by the lru")
522522
),
@@ -1747,8 +1747,8 @@ Cache::close_ertr::future<> Cache::close()
17471747
stats.dirty_bytes,
17481748
get_oldest_dirty_from().value_or(JOURNAL_SEQ_NULL),
17491749
get_oldest_backref_dirty_from().value_or(JOURNAL_SEQ_NULL),
1750-
lru.get_current_contents_extents(),
1751-
lru.get_current_contents_bytes(),
1750+
lru.get_current_num_extents(),
1751+
lru.get_current_size_bytes(),
17521752
extents.size(),
17531753
extents.get_bytes());
17541754
root.reset();

src/crimson/os/seastore/cache.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1429,33 +1429,33 @@ class Cache {
14291429
const size_t capacity = 0;
14301430

14311431
// current size (bytes)
1432-
size_t contents = 0;
1432+
size_t current_size = 0;
14331433

14341434
CachedExtent::primary_ref_list lru;
14351435

14361436
void do_remove_from_lru(CachedExtent &extent) {
14371437
assert(extent.is_stable_clean() && !extent.is_placeholder());
14381438
assert(extent.primary_ref_list_hook.is_linked());
14391439
assert(lru.size() > 0);
1440-
assert(contents >= extent.get_length());
1440+
assert(current_size >= extent.get_length());
14411441

14421442
lru.erase(lru.s_iterator_to(extent));
1443-
contents -= extent.get_length();
1443+
current_size -= extent.get_length();
14441444
intrusive_ptr_release(&extent);
14451445
}
14461446

14471447
public:
14481448
LRU(size_t capacity) : capacity(capacity) {}
14491449

1450-
size_t get_capacity() const {
1450+
size_t get_capacity_bytes() const {
14511451
return capacity;
14521452
}
14531453

1454-
size_t get_current_contents_bytes() const {
1455-
return contents;
1454+
size_t get_current_size_bytes() const {
1455+
return current_size;
14561456
}
14571457

1458-
size_t get_current_contents_extents() const {
1458+
size_t get_current_num_extents() const {
14591459
return lru.size();
14601460
}
14611461

@@ -1473,17 +1473,17 @@ class Cache {
14731473
if (extent.primary_ref_list_hook.is_linked()) {
14741474
// present, move to top (back)
14751475
assert(lru.size() > 0);
1476-
assert(contents >= extent.get_length());
1476+
assert(current_size >= extent.get_length());
14771477
lru.erase(lru.s_iterator_to(extent));
14781478
lru.push_back(extent);
14791479
} else {
14801480
// absent, add to top (back)
1481-
contents += extent.get_length();
1481+
current_size += extent.get_length();
14821482
intrusive_ptr_add_ref(&extent);
14831483
lru.push_back(extent);
14841484

14851485
// trim to capacity
1486-
while (contents > capacity) {
1486+
while (current_size > capacity) {
14871487
do_remove_from_lru(lru.front());
14881488
}
14891489
}

0 commit comments

Comments
 (0)