Merge pull request ceph#66235 from jzhu116-bloomberg/wip-co-throttle-fix

cbodley · web-flow · commit 82862b659233 · 2025-11-13T14:21:56.000-05:00
rgw: fix boost::intrusive::list iterator handling for erase

Reviewed-by: Casey Bodley &lt;cbodley@redhat.com&gt;
diff --git a/src/common/async/detail/co_throttle_impl.h b/src/common/async/detail/co_throttle_impl.h
@@ -194,7 +194,7 @@ class co_throttle_impl :
           to_cancel = std::move(outstanding);
         }
 
-        for (auto i = to_cancel.begin(); i != to_cancel.end(); ++i) {
+        for (auto i = to_cancel.begin(); i != to_cancel.end();) {
           child& c = *i;
           i = to_cancel.erase(i);
 

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ class co_throttle_impl :`
`194`	`194`	`to_cancel = std::move(outstanding);`
`195`	`195`	`}`
`196`	`196`
`197`		`- for (auto i = to_cancel.begin(); i != to_cancel.end(); ++i) {`
	`197`	`+ for (auto i = to_cancel.begin(); i != to_cancel.end();) {`
`198`	`198`	`child& c = *i;`
`199`	`199`	`i = to_cancel.erase(i);`
`200`	`200`