Merge pull request ceph#65134 from xxhdx1985126/wip-seastore-clone-range-latest

crimson/os/seastore: OP_CLONERANGE2 support ---- another approach

Reviewed-by: Samuel Just <[email protected]>

Author: athanatos

qa/suites/crimson-rados/thrash_simple/thrashers/simple.yaml

@@ -25,7 +25,6 @@ tasks:
     sighup_delay: 0
     min_in: 3
     noscrub_toggle_delay: 0
-    chance_down: 0
     chance_thrash_pg_upmap: 0
     reweight_osd: 0
     thrash_primary_affinity: false

src/crimson/os/seastore/lba/btree_lba_manager.cc

@@ -427,17 +427,21 @@ BtreeLBAManager::clone_mapping(
   LBAMapping pos,
   LBAMapping mapping,
   laddr_t laddr,
+  extent_len_t offset,
+  extent_len_t len,
   bool updateref)
 {
   LOG_PREFIX(BtreeLBAManager::clone_mapping);
   assert(pos.is_viewable());
   assert(mapping.is_viewable());
-  DEBUGT("pos={}, mapping={}, laddr={}, updateref={}",
-    t, pos, mapping, laddr, updateref);
+  DEBUGT("pos={}, mapping={}, laddr={}, {}~{} updateref={}",
+    t, pos, mapping, laddr, offset, len, updateref);
+  assert(offset + len <= mapping.get_length());
   struct state_t {
     LBAMapping pos;
     LBAMapping mapping;
     laddr_t laddr;
+    extent_len_t offset;
     extent_len_t len;
   };
   auto c = get_context(t);
@@ -464,11 +468,10 @@ BtreeLBAManager::clone_mapping(
       return update_refcount_iertr::make_ready_future<
 	LBAMapping>(std::move(mapping));
     }
-  }).si_then([c, this, pos=std::move(pos),
-		      laddr](auto mapping) mutable {
-    auto len = mapping.get_length();
+  }).si_then([c, this, pos=std::move(pos), len,
+	      offset, laddr](auto mapping) mutable {
     return seastar::do_with(
-      state_t{std::move(pos), std::move(mapping), laddr, len},
+      state_t{std::move(pos), std::move(mapping), laddr, offset, len},
       [this, c](auto &state) {
       return with_btree<LBABtree>(
 	cache,
@@ -479,17 +482,15 @@ BtreeLBAManager::clone_mapping(
 	).si_then([&state, c, &btree]() mutable {
 	  auto &cursor = state.pos.get_effective_cursor();
 	  assert(state.laddr + state.len <= cursor.key);
+          auto inter_key = state.mapping.is_indirect()
+            ? state.mapping.get_intermediate_key()
+            : state.mapping.get_key();
+          inter_key = (inter_key + state.offset).checked_to_laddr();
 	  return btree.insert(
 	    c,
 	    btree.make_partial_iter(c, cursor),
 	    state.laddr,
-	    lba_map_val_t{
-	      state.len,
-	      state.mapping.is_indirect()
-		? state.mapping.get_intermediate_key()
-		: state.mapping.get_key(),
-	      EXTENT_DEFAULT_REF_COUNT,
-	      0});
+            lba_map_val_t{state.len, inter_key, EXTENT_DEFAULT_REF_COUNT, 0});
 	}).si_then([c, &state](auto p) {
 	  auto &[iter, inserted] = p;
 	  auto &leaf_node = *iter.get_leaf_node();

src/crimson/os/seastore/lba/btree_lba_manager.h

@@ -105,6 +105,8 @@ class BtreeLBAManager : public LBAManager {
     LBAMapping pos,
     LBAMapping mapping,
     laddr_t laddr,
+    extent_len_t offset,
+    extent_len_t len,
     bool updateref) final;
 
 #ifdef UNIT_TESTS_BUILT

src/crimson/os/seastore/lba_manager.h

@@ -117,15 +117,19 @@ class LBAManager {
   using clone_mapping_iertr = alloc_extent_iertr;
   using clone_mapping_ret = clone_mapping_iertr::future<clone_mapping_ret_t>;
   /*
-   * Clones "mapping" at the position "pos" with new laddr "laddr", if updateref
-   * is true, update the refcount of the mapping "mapping"
+   * Clones (part of) "mapping" at the position "pos" with the new lba key "laddr".
    */
   virtual clone_mapping_ret clone_mapping(
     Transaction &t,
-    LBAMapping pos,
-    LBAMapping mapping,
-    laddr_t laddr,
-    bool updateref) = 0;
+    LBAMapping pos,		// the destined position
+    LBAMapping mapping,		// the mapping to be cloned
+    laddr_t laddr,		// the new lba key of the cloned mapping
+    extent_len_t offset,	// the offset of the part to be cloned,
+				// relative to the start of the mapping.
+    extent_len_t len,		// the length of the part to be cloned
+    bool updateref		// whether to update the refcount of the
+				// direct mapping
+  ) = 0;
 
   virtual alloc_extent_ret reserve_region(
     Transaction &t,

src/crimson/os/seastore/lba_mapping.h

@@ -111,6 +111,7 @@ class LBAMapping {
   bool is_zero_reserved() const {
     return !is_indirect() && get_val().is_zero();
   }
+  // true if the mapping corresponds to real data
   bool is_real() const {
     return !is_indirect() && !get_val().is_zero();
   }
@@ -147,6 +148,10 @@ class LBAMapping {
     return direct_cursor->get_laddr();
   }
 
+  laddr_t get_end() const {
+    return (get_key() + get_length()).checked_to_laddr();
+  }
+
    // An lba pin may be indirect, see comments in lba/btree_lba_manager.h
   laddr_t get_intermediate_key() const {
     assert(is_indirect());