Skip to content

Commit 8d1033e

Browse files
mds: Remove unnecessary std::move on const expression in MetricsHandler::handle_payload
Fixes: https://tracker.ceph.com/issues/73430 Signed-off-by: Edwin Rodriguez <[email protected]>
1 parent 353eaff commit 8d1033e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/mds/MetricsHandler.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,9 @@ std::chrono::steady_clock::now().time_since_epoch()).count());
368368
auto& vec = subvolume_metrics_map[path];
369369

370370
dout(20) << " accumulating subv_metric " << payload.subvolume_metrics[i] << dendl;
371-
vec.emplace_back(std::move(payload.subvolume_metrics[i]));
371+
// std::move of the const expression of the trivially-copyable type 'const value_type'
372+
// (aka 'const AggregatedIOMetrics') has no effect; remove std::move()
373+
vec.emplace_back(payload.subvolume_metrics[i]);
372374
vec.back().time_stamp = now_ms;
373375
}
374376
}

0 commit comments

Comments
 (0)