Skip to content

Commit 90c1485

Browse files
author
Naman Munet
committed
mgr/dashboard: add footer to side-panel
Fixes: https://tracker.ceph.com/issues/73788Wq Signed-off-by: Naman Munet <[email protected]>
1 parent 060b69c commit 90c1485

File tree

2 files changed

+33
-18
lines changed

2 files changed

+33
-18
lines changed

src/pybind/mgr/dashboard/frontend/src/app/shared/components/side-panel/side-panel.component.html

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,18 @@
44

55
<cds-panel [expanded]="expanded"
66
[attr.panel-size]="size">
7-
<cds-icon-button
8-
kind="ghost"
9-
class="float-end"
10-
title="Close"
11-
(click)="close()">
12-
<svg
13-
class="cds--btn__icon"
14-
cdsIcon="close"></svg>
15-
</cds-icon-button>
16-
17-
<div
18-
class="panel-header spacing-03"
19-
*ngIf="headerText">
20-
{{ headerText }}
21-
</div>
22-
23-
<div class="spacing-03">
24-
<ng-content select=".panel-content"></ng-content>
7+
<div>
8+
<cds-icon-button kind="ghost"
9+
class="float-end"
10+
title="Close"
11+
(click)="close()">
12+
<svg cdsIcon="close"></svg>
13+
</cds-icon-button>
14+
<div class="panel-header"
15+
*ngIf="headerText">
16+
{{ headerText }}
17+
</div>
2518
</div>
19+
<ng-content select=".panel-content"></ng-content>
20+
<ng-content select=".panel-footer"></ng-content>
2621
</cds-panel>

src/pybind/mgr/dashboard/frontend/src/app/shared/components/side-panel/side-panel.component.scss

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
@use './src/styles/vendor/variables' as vv;
2+
@use '@carbon/layout';
3+
@use '@carbon/styles/scss/theme';
24

35
:host ::ng-deep cds-panel {
46
&[panel-size='sm'] .cds--header-panel--expanded {
@@ -16,6 +18,24 @@
1618
.cds--header-panel--expanded {
1719
background-color: vv.$white;
1820
max-inline-size: 100%;
21+
overflow: hidden;
22+
display: grid;
23+
grid-template-rows: auto 1fr auto;
24+
}
25+
26+
.panel-header {
27+
padding: layout.$spacing-04 layout.$spacing-04 0 layout.$spacing-04;
28+
}
29+
30+
.panel-content {
31+
overflow: auto;
32+
padding: 0 layout.$spacing-04 0 layout.$spacing-04;
33+
}
34+
35+
.panel-footer {
36+
display: flex;
37+
justify-content: flex-end;
38+
border-top: 1px solid theme.$border-subtle-02;
1939
}
2040
}
2141

0 commit comments

Comments
 (0)