Skip to content

Commit 97cb38d

Browse files
authored
Merge pull request ceph#56728 from pritha-srivastava/wip-rgw-d4n-compilation-errors
rgw/d4n: fix compilation issue when WITH_RADOSGW_D4N=OFF. Reviewed-by: Daniel Gryniewicz <[email protected]> Reviewed-by: J. Eric Ivancich <[email protected]>
2 parents 17c90ba + 8bb207a commit 97cb38d

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

src/rgw/CMakeLists.txt

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,6 @@ set(librgw_common_srcs
116116
rgw_role.cc
117117
rgw_sal.cc
118118
rgw_sal_filter.cc
119-
rgw_redis_driver.cc
120-
rgw_ssd_driver.cc
121119
rgw_string.cc
122120
rgw_tag.cc
123121
rgw_tag_s3.cc
@@ -150,9 +148,6 @@ set(librgw_common_srcs
150148
rgw_tracer.cc
151149
rgw_lua_background.cc
152150
rgw_data_access.cc
153-
driver/d4n/d4n_directory.cc
154-
driver/d4n/d4n_policy.cc
155-
driver/d4n/rgw_sal_d4n.cc
156151
driver/rados/cls_fifo_legacy.cc
157152
driver/rados/rgw_bucket.cc
158153
driver/rados/rgw_bucket_sync.cc
@@ -247,6 +242,15 @@ if(WITH_RADOSGW_ARROW_FLIGHT)
247242
list(APPEND librgw_common_srcs rgw_flight.cc rgw_flight_frontend.cc)
248243
endif(WITH_RADOSGW_ARROW_FLIGHT)
249244

245+
if(WITH_RADOSGW_D4N)
246+
list(APPEND librgw_common_srcs
247+
rgw_redis_driver.cc
248+
rgw_ssd_driver.cc
249+
driver/d4n/d4n_directory.cc
250+
driver/d4n/d4n_policy.cc
251+
driver/d4n/rgw_sal_d4n.cc)
252+
endif()
253+
250254
add_library(rgw_common STATIC ${librgw_common_srcs})
251255

252256
include(CheckCXXCompilerFlag)

src/test/rgw/CMakeLists.txt

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ add_executable(ceph_test_rgw_d4n_directory
2525
test_d4n_directory.cc
2626
)
2727
target_include_directories(ceph_test_rgw_d4n_directory
28-
PUBLIC "${CMAKE_SOURCE_DIR}/src/dmclock/support/src"
2928
SYSTEM PRIVATE "${CMAKE_SOURCE_DIR}/src/rgw/driver/d4n")
3029
target_link_libraries(ceph_test_rgw_d4n_directory PRIVATE
3130
rgw_common
@@ -42,7 +41,6 @@ add_executable(ceph_test_rgw_d4n_policy
4241
test_d4n_policy.cc
4342
)
4443
target_include_directories(ceph_test_rgw_d4n_policy
45-
PUBLIC "${CMAKE_SOURCE_DIR}/src/dmclock/support/src"
4644
SYSTEM PRIVATE "${CMAKE_SOURCE_DIR}/src/rgw/")
4745
target_link_libraries(ceph_test_rgw_d4n_policy PRIVATE
4846
rgw_common
@@ -59,7 +57,6 @@ add_executable(ceph_test_rgw_redis_driver
5957
test_redis_driver.cc
6058
)
6159
target_include_directories(ceph_test_rgw_redis_driver
62-
PUBLIC "${CMAKE_SOURCE_DIR}/src/dmclock/support/src"
6360
SYSTEM PRIVATE "${CMAKE_SOURCE_DIR}/src/rgw/")
6461
target_link_libraries(ceph_test_rgw_redis_driver PRIVATE
6562
rgw_common
@@ -71,6 +68,22 @@ target_link_libraries(ceph_test_rgw_redis_driver PRIVATE
7168
)
7269
target_link_libraries(ceph_test_rgw_redis_driver PRIVATE spawn)
7370
install(TARGETS ceph_test_rgw_redis_driver DESTINATION ${CMAKE_INSTALL_BINDIR})
71+
72+
add_executable(ceph_test_rgw_ssd_driver
73+
test_ssd_driver.cc
74+
)
75+
target_include_directories(ceph_test_rgw_ssd_driver
76+
SYSTEM PRIVATE "${CMAKE_SOURCE_DIR}/src/rgw/")
77+
target_link_libraries(ceph_test_rgw_ssd_driver PRIVATE
78+
rgw_common
79+
librados
80+
ceph-common
81+
${rgw_libs}
82+
${UNITTEST_LIBS}
83+
${EXTRALIBS}
84+
)
85+
target_link_libraries(ceph_test_rgw_ssd_driver PRIVATE spawn)
86+
install(TARGETS ceph_test_rgw_ssd_driver DESTINATION ${CMAKE_INSTALL_BINDIR})
7487
endif()
7588

7689
#unittest_rgw_bencode
@@ -119,23 +132,6 @@ add_executable(unittest_rgw_ratelimit test_rgw_ratelimit.cc $<TARGET_OBJECTS:uni
119132
target_link_libraries(unittest_rgw_ratelimit ${rgw_libs})
120133
add_ceph_unittest(unittest_rgw_ratelimit)
121134

122-
add_executable(ceph_test_rgw_ssd_driver
123-
test_ssd_driver.cc
124-
)
125-
target_include_directories(ceph_test_rgw_ssd_driver
126-
PUBLIC "${CMAKE_SOURCE_DIR}/src/dmclock/support/src"
127-
SYSTEM PRIVATE "${CMAKE_SOURCE_DIR}/src/rgw/")
128-
target_link_libraries(ceph_test_rgw_ssd_driver PRIVATE
129-
rgw_common
130-
librados
131-
ceph-common
132-
${rgw_libs}
133-
${UNITTEST_LIBS}
134-
${EXTRALIBS}
135-
)
136-
target_link_libraries(ceph_test_rgw_ssd_driver PRIVATE spawn)
137-
install(TARGETS ceph_test_rgw_ssd_driver DESTINATION ${CMAKE_INSTALL_BINDIR})
138-
139135
# ceph_test_rgw_manifest
140136
set(test_rgw_manifest_srcs test_rgw_manifest.cc)
141137
add_executable(ceph_test_rgw_manifest

0 commit comments

Comments
 (0)