Skip to content

Commit 9821bf8

Browse files
committed
qa/scrub: change 'bin/ceph' to 'ceph'
Signed-off-by: Ronen Friedman <[email protected]>
1 parent 8ac0470 commit 9821bf8

File tree

3 files changed

+39
-39
lines changed

3 files changed

+39
-39
lines changed

qa/standalone/scrub/osd-recovery-scrub.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ function wait_for_scrub_mod() {
163163
fi
164164
sleep 1
165165
# are we still the primary?
166-
local current_primary=`bin/ceph pg $pgid query | jq '.acting[0]' `
166+
local current_primary=`./bin/ceph pg $pgid query | jq '.acting[0]' `
167167
if [ $orig_primary != $current_primary ]; then
168168
echo $orig_primary no longer primary for $pgid
169169
return 0
@@ -194,7 +194,7 @@ function pg_scrub_mod() {
194194

195195
local last_scrub=$(get_last_scrub_stamp $pgid)
196196
# locate the primary
197-
local my_primary=`bin/ceph pg $pgid query | jq '.acting[0]' `
197+
local my_primary=`./bin/ceph pg $pgid query | jq '.acting[0]' `
198198
local recovery=false
199199
ceph pg scrub $pgid
200200
#ceph --format json pg dump pgs | jq ".pg_stats | .[] | select(.pgid == \"$pgid\") | .state"

qa/standalone/scrub/osd-scrub-test.sh

Lines changed: 36 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -692,28 +692,28 @@ function wait_initial_scrubs() {
692692

693693
# set a long schedule for the periodic scrubs. Wait for the
694694
# initial 'no previous scrub is known' scrubs to finish for all PGs.
695-
bin/ceph tell osd.* config set osd_scrub_min_interval 7200
696-
bin/ceph tell osd.* config set osd_deep_scrub_interval 14400
697-
bin/ceph tell osd.* config set osd_max_scrubs 32
698-
bin/ceph tell osd.* config set osd_scrub_sleep 0
699-
bin/ceph tell osd.* config set osd_shallow_scrub_chunk_max 10
700-
bin/ceph tell osd.* config set osd_scrub_chunk_max 10
695+
ceph tell osd.* config set osd_scrub_min_interval 7200
696+
ceph tell osd.* config set osd_deep_scrub_interval 14400
697+
ceph tell osd.* config set osd_max_scrubs 32
698+
ceph tell osd.* config set osd_scrub_sleep 0
699+
ceph tell osd.* config set osd_shallow_scrub_chunk_max 10
700+
ceph tell osd.* config set osd_scrub_chunk_max 10
701701

702702
for pg in "${!pg_to_prim_dict[@]}"; do
703703
(( extr_dbg >= 1 )) && echo "Scheduling initial scrub for $pg"
704-
bin/ceph tell $pg scrub || return 1
704+
ceph tell $pg scrub || return 1
705705
done
706706

707707
sleep 1
708-
(( extr_dbg >= 1 )) && bin/ceph pg dump pgs --format=json-pretty | \
708+
(( extr_dbg >= 1 )) && ceph pg dump pgs --format=json-pretty | \
709709
jq '.pg_stats | map(select(.last_scrub_duration == 0)) | map({pgid: .pgid, last_scrub_duration: .last_scrub_duration})'
710710

711711
tout=20
712712
while [ $tout -gt 0 ] ; do
713713
sleep 0.5
714-
(( extr_dbg >= 2 )) && bin/ceph pg dump pgs --format=json-pretty | \
714+
(( extr_dbg >= 2 )) && ceph pg dump pgs --format=json-pretty | \
715715
jq '.pg_stats | map(select(.last_scrub_duration == 0)) | map({pgid: .pgid, last_scrub_duration: .last_scrub_duration})'
716-
not_done=$(bin/ceph pg dump pgs --format=json-pretty | \
716+
not_done=$(ceph pg dump pgs --format=json-pretty | \
717717
jq '.pg_stats | map(select(.last_scrub_duration == 0)) | map({pgid: .pgid, last_scrub_duration: .last_scrub_duration})' | wc -l )
718718
# note that we should ignore a header line
719719
if [ "$not_done" -le 1 ]; then
@@ -782,14 +782,14 @@ function TEST_abort_periodic_for_operator() {
782782
wait_initial_scrubs pg_pr || return 1
783783

784784
# limit all OSDs to one scrub at a time
785-
bin/ceph tell osd.* config set osd_max_scrubs 1
786-
bin/ceph tell osd.* config set osd_stats_update_period_not_scrubbing 1
785+
ceph tell osd.* config set osd_max_scrubs 1
786+
ceph tell osd.* config set osd_stats_update_period_not_scrubbing 1
787787

788788
# configure for slow scrubs
789-
bin/ceph tell osd.* config set osd_scrub_sleep 3
790-
bin/ceph tell osd.* config set osd_shallow_scrub_chunk_max 2
791-
bin/ceph tell osd.* config set osd_scrub_chunk_max 2
792-
(( extr_dbg >= 2 )) && bin/ceph tell osd.2 dump_scrub_reservations --format=json-pretty
789+
ceph tell osd.* config set osd_scrub_sleep 3
790+
ceph tell osd.* config set osd_shallow_scrub_chunk_max 2
791+
ceph tell osd.* config set osd_scrub_chunk_max 2
792+
(( extr_dbg >= 2 )) && ceph tell osd.2 dump_scrub_reservations --format=json-pretty
793793

794794
# the first PG to work with:
795795
local pg1="1.0"
@@ -812,7 +812,7 @@ function TEST_abort_periodic_for_operator() {
812812
fi
813813

814814
# the common primary is allowed two concurrent scrubs
815-
bin/ceph tell osd."${pg_pr[$pg1]}" config set osd_max_scrubs 2
815+
ceph tell osd."${pg_pr[$pg1]}" config set osd_max_scrubs 2
816816
echo "The two PGs to manipulate are $pg1 and $pg2"
817817

818818
set_query_debug "$pg1"
@@ -821,31 +821,31 @@ function TEST_abort_periodic_for_operator() {
821821
local is_act
822822
for i in $( seq 1 3 )
823823
do
824-
is_act=$(bin/ceph pg "$pg1" query | jq '.scrubber.active')
824+
is_act=$(ceph pg "$pg1" query | jq '.scrubber.active')
825825
if [[ "$is_act" = "false" ]]; then
826826
break
827827
fi
828828
echo "Still waiting for pg $pg1 to finish scrubbing"
829829
sleep 0.7
830830
done
831-
bin/ceph pg dump pgs
831+
ceph pg dump pgs
832832
if [[ "$is_act" != "false" ]]; then
833-
bin/ceph pg "$pg1" query
833+
ceph pg "$pg1" query
834834
echo "PG $pg1 appears to be still scrubbing"
835835
return 1
836836
fi
837837
sleep 0.5
838838

839839
echo "Initiating a periodic scrub of $pg1"
840-
(( extr_dbg >= 2 )) && bin/ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
841-
bin/ceph tell $pg1 schedule-deep-scrub || return 1
840+
(( extr_dbg >= 2 )) && ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
841+
ceph tell $pg1 schedule-deep-scrub || return 1
842842
sleep 1
843-
(( extr_dbg >= 2 )) && bin/ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
843+
(( extr_dbg >= 2 )) && ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
844844

845845
for i in $( seq 1 14 )
846846
do
847847
sleep 0.5
848-
stt=$(bin/ceph pg "$pg1" query | jq '.scrubber')
848+
stt=$(ceph pg "$pg1" query | jq '.scrubber')
849849
is_active=$(echo $stt | jq '.active')
850850
is_reserving_replicas=$(echo $stt | jq '.is_reserving_replicas')
851851
if [[ "$is_active" = "true" && "$is_reserving_replicas" = "false" ]]; then
@@ -854,49 +854,49 @@ function TEST_abort_periodic_for_operator() {
854854
echo "Still waiting for pg $pg1 to start scrubbing: $stt"
855855
done
856856
if [[ "$is_active" != "true" || "$is_reserving_replicas" != "false" ]]; then
857-
bin/ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
857+
ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
858858
echo "The scrub is not active or is reserving replicas"
859859
return 1
860860
fi
861-
(( extr_dbg >= 2 )) && bin/ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
861+
(( extr_dbg >= 2 )) && ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
862862

863863

864864
# PG 1 is scrubbing, and has reserved the replicas - soem of which are shared
865865
# by PG 2. As the max-scrubs was set to 1, that should prevent PG 2 from
866866
# reserving its replicas.
867867

868-
(( extr_dbg >= 1 )) && bin/ceph tell osd.* dump_scrub_reservations --format=json-pretty
868+
(( extr_dbg >= 1 )) && ceph tell osd.* dump_scrub_reservations --format=json-pretty
869869

870870
# now - the 2'nd scrub - which should be blocked on reserving
871871
set_query_debug "$pg2"
872-
bin/ceph tell "$pg2" schedule-deep-scrub
872+
ceph tell "$pg2" schedule-deep-scrub
873873
sleep 0.5
874874
(( extr_dbg >= 2 )) && echo "===================================================================================="
875-
(( extr_dbg >= 2 )) && bin/ceph pg "$pg2" query -f json-pretty | jq '.scrubber'
876-
(( extr_dbg >= 2 )) && bin/ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
875+
(( extr_dbg >= 2 )) && ceph pg "$pg2" query -f json-pretty | jq '.scrubber'
876+
(( extr_dbg >= 2 )) && ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
877877
sleep 1
878878
(( extr_dbg >= 2 )) && echo "===================================================================================="
879-
(( extr_dbg >= 2 )) && bin/ceph pg "$pg2" query -f json-pretty | jq '.scrubber'
880-
(( extr_dbg >= 2 )) && bin/ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
879+
(( extr_dbg >= 2 )) && ceph pg "$pg2" query -f json-pretty | jq '.scrubber'
880+
(( extr_dbg >= 2 )) && ceph pg "$pg1" query -f json-pretty | jq '.scrubber'
881881

882882
# make sure pg2 scrub is stuck in the reserving state
883-
local stt2=$(bin/ceph pg "$pg2" query | jq '.scrubber')
883+
local stt2=$(ceph pg "$pg2" query | jq '.scrubber')
884884
local pg2_is_reserving
885885
pg2_is_reserving=$(echo $stt2 | jq '.is_reserving_replicas')
886886
if [[ "$pg2_is_reserving" != "true" ]]; then
887887
echo "The scheduled scrub for $pg2 should have been stuck"
888-
bin/ceph pg dump pgs
888+
ceph pg dump pgs
889889
return 1
890890
fi
891891

892892
# now - issue an operator-initiated scrub on pg2.
893893
# The periodic scrub should be aborted, and the operator-initiated scrub should start.
894894
echo "Instructing $pg2 to perform a high-priority scrub"
895-
bin/ceph tell "$pg2" scrub
895+
ceph tell "$pg2" scrub
896896
for i in $( seq 1 10 )
897897
do
898898
sleep 0.5
899-
stt2=$(bin/ceph pg "$pg2" query | jq '.scrubber')
899+
stt2=$(ceph pg "$pg2" query | jq '.scrubber')
900900
pg2_is_active=$(echo $stt2 | jq '.active')
901901
pg2_is_reserving=$(echo $stt2 | jq '.is_reserving_replicas')
902902
if [[ "$pg2_is_active" = "true" && "$pg2_is_reserving" != "true" ]]; then

qa/standalone/scrub/scrub-helpers.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,7 +320,7 @@ function build_pg_dicts {
320320

321321
# if the infile name is '-', fetch the dump directly from the ceph cluster
322322
if [[ $infile == "-" ]]; then
323-
local -r ceph_cmd="bin/ceph pg dump pgs_brief -f=json-pretty"
323+
local -r ceph_cmd="ceph pg dump pgs_brief -f=json-pretty"
324324
local -r ceph_cmd_out=$(eval $ceph_cmd)
325325
local -r ceph_cmd_rc=$?
326326
if [[ $ceph_cmd_rc -ne 0 ]]; then

0 commit comments

Comments
 (0)