Skip to content

Commit 9944ed1

Browse files
authored
Merge pull request ceph#61983 from adk3798/cephadm-fix-apply-same-nvmeof-service
mgr/cephadm: don't block matching group for identical nvmeof services Reviewed-by: Aviv Caro <[email protected]>
2 parents 8aa9829 + e681d37 commit 9944ed1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/pybind/mgr/cephadm/module.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3433,7 +3433,7 @@ def _apply_service_spec(self, spec: ServiceSpec) -> str:
34333433
f"group name '{nvmeof_spec.group}' and service id '{nvmeof_spec.service_id}'")
34343434
for sspec in [s.spec for s in self.spec_store.get_by_service_type('nvmeof')]:
34353435
nspec = cast(NvmeofServiceSpec, sspec)
3436-
if nvmeof_spec.group == nspec.group:
3436+
if nvmeof_spec.group == nspec.group and nvmeof_spec.service_id != nspec.service_id:
34373437
raise OrchestratorError(f"Cannot create nvmeof service with group {nvmeof_spec.group}. That group is already "
34383438
f"being used by the service {nspec.service_name()}")
34393439

0 commit comments

Comments
 (0)