Skip to content

Commit 9a85c27

Browse files
Tomer HaskalovitchTomer Haskalovitch
authored andcommitted
mgr/dashboard: migrate nvmeof pr ceph#1308 to new cli
Signed-off-by: Tomer Haskalovitch <[email protected]>
1 parent 4c6304e commit 9a85c27

File tree

1 file changed

+13
-8
lines changed
  • src/pybind/mgr/dashboard/controllers

1 file changed

+13
-8
lines changed

src/pybind/mgr/dashboard/controllers/nvmeof.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# -*- coding: utf-8 -*-
22
import logging
3-
from typing import Any, Dict, Optional
3+
from typing import Any, Dict, List, Optional
44

55
import cherrypy
66
from orchestrator import OrchestratorError
@@ -100,10 +100,11 @@ class NVMeoFSpdk(RESTController):
100100
@NvmeofCLICommand("nvmeof spdk_log_level get", model.SpdkNvmfLogFlagsAndLevelInfo)
101101
@convert_to_model(model.SpdkNvmfLogFlagsAndLevelInfo)
102102
@handle_nvmeof_error
103-
def get_spdk_log_level(self, gw_group: Optional[str] = None, traddr: Optional[str] = None):
103+
def get_spdk_log_level(self, all_log_flags: Optional[bool] = None,
104+
gw_group: Optional[str] = None, traddr: Optional[str] = None):
104105
spdk_log_level = NVMeoFClient(gw_group=gw_group,
105106
traddr=traddr).stub.get_spdk_nvmf_log_flags_and_level(
106-
NVMeoFClient.pb2.get_spdk_nvmf_log_flags_and_level_req()
107+
NVMeoFClient.pb2.get_spdk_nvmf_log_flags_and_level_req(all_log_flags=all_log_flags)
107108
)
108109
return spdk_log_level
109110

@@ -114,13 +115,15 @@ def get_spdk_log_level(self, gw_group: Optional[str] = None, traddr: Optional[st
114115
@handle_nvmeof_error
115116
def set_spdk_log_level(self, log_level: Optional[str] = None,
116117
print_level: Optional[str] = None,
118+
extra_log_flags: Optional[List[str]] = None,
117119
gw_group: Optional[str] = None, traddr: Optional[str] = None):
118120
log_level = log_level.upper() if log_level else None
119121
print_level = print_level.upper() if print_level else None
120122
spdk_log_level = NVMeoFClient(gw_group=gw_group,
121-
traddr=traddr).stub.set_spdk_nvmf_logs_req(
123+
traddr=traddr).stub.set_spdk_nvmf_logs(
122124
NVMeoFClient.pb2.set_spdk_nvmf_logs_req(log_level=log_level,
123-
print_level=print_level)
125+
print_level=print_level,
126+
extra_log_flags=extra_log_flags)
124127
)
125128
return spdk_log_level
126129

@@ -129,11 +132,12 @@ def set_spdk_log_level(self, log_level: Optional[str] = None,
129132
@NvmeofCLICommand("nvmeof spdk_log_level disable", model.RequestStatus)
130133
@convert_to_model(model.RequestStatus)
131134
@handle_nvmeof_error
132-
def disable_spdk_log_level(self, gw_group: Optional[str] = None,
135+
def disable_spdk_log_level(self, extra_log_flags: Optional[List[str]] = None,
136+
gw_group: Optional[str] = None,
133137
traddr: Optional[str] = None):
134138
spdk_log_level = NVMeoFClient(gw_group=gw_group,
135139
traddr=traddr).stub.disable_spdk_nvmf_logs(
136-
NVMeoFClient.pb2.disable_spdk_nvmf_logs_req()
140+
NVMeoFClient.pb2.disable_spdk_nvmf_logs_req(extra_log_flags=extra_log_flags)
137141
)
138142
return spdk_log_level
139143

@@ -874,7 +878,8 @@ class NVMeoFConnection(RESTController):
874878
@NvmeofCLICommand("nvmeof connection list", model.ConnectionList)
875879
@convert_to_model(model.ConnectionList)
876880
@handle_nvmeof_error
877-
def list(self, nqn: Optional[str] = None, gw_group: Optional[str] = None, traddr: Optional[str] = None):
881+
def list(self, nqn: Optional[str] = None,
882+
gw_group: Optional[str] = None, traddr: Optional[str] = None):
878883
if not nqn:
879884
nqn = '*'
880885
return NVMeoFClient(gw_group=gw_group, traddr=traddr).stub.list_connections(

0 commit comments

Comments
 (0)